[PATCH -next] rv/reactor: add __init/__exit annotations to module init/exit funcs

[PATCH -next] rv/reactor: add __init/__exit annotations to module init/exit funcs

[Xiu Jianfeng]

Add missing __init/__exit annotations to module init/exit funcs.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 kernel/trace/rv/reactor_panic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
index b698d05dd069..d65f6c25a87c 100644
--- a/kernel/trace/rv/reactor_panic.c
+++ b/kernel/trace/rv/reactor_panic.c
@@ -24,13 +24,13 @@ static struct rv_reactor rv_panic = {
 	.react = rv_panic_reaction
 };
 
-static int register_react_panic(void)
+static int __init register_react_panic(void)
 {
 	rv_register_reactor(&rv_panic);
 	return 0;
 }
 
-static void unregister_react_panic(void)
+static void __exit unregister_react_panic(void)
 {
 	rv_unregister_reactor(&rv_panic);
 }
-- 
2.17.1

Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module init/exit funcs

[Daniel Bristot de Oliveira]

Hi Xiu
On 9/6/22 13:18, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.

Regarding the Subject, this patch is not -next. I would suggest only using -next
when you are fixing something in the linux-next (which is not the case here).

You can also fix this for the printk reactor. Do you mind re-sending this patch
with including the printk reactor?

If you found it using an automatic tool, please add information to the patch.
Also, try to figure out why it pointed to the panic reactor but did not point to
printk.

Add to v2:

Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")

> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Thanks
-- Daniel

Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module init/exit funcs

[xiujianfeng]

Hi,

在 2022/9/6 21:43, Daniel Bristot de Oliveira 写道:
> 
> Hi Xiu
> On 9/6/22 13:18, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Regarding the Subject, this patch is not -next. I would suggest only using -next
> when you are fixing something in the linux-next (which is not the case here).
> 
> You can also fix this for the printk reactor. Do you mind re-sending this patch
> with including the printk reactor?

No problem, V2 already sent.

> 
> If you found it using an automatic tool, please add information to the patch.
> Also, try to figure out why it pointed to the panic reactor but did not point to
> printk.

Thanks, I found it by review not tools.

> 
> Add to v2:
> 
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> 
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> 
> Thanks
> -- Daniel
> .
>