From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
Date: Tue, 22 Aug 2023 21:03:57 +0200 [thread overview]
Message-ID: <65c46da5-b03b-41cd-9030-8ebd7ae7b1e9@linaro.org> (raw)
In-Reply-To: <b5b3a8a6-c54d-c503-db76-c8c38942b3b0@linaro.org>
On 22.08.2023 21:03, Bryan O'Donoghue wrote:
> On 22/08/2023 17:32, Konrad Dybcio wrote:
>>> val = 1 << CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
>>> + if (vc > 3)
>> I hope you don't pull your hair out, but I think GENMASK(1,0) could be
>
>
> I generally dislike the pattern of 1 << value in this code but, it's not something I'm proposing to solve at this time.
>
>> in order here with a comment about the bitlength requirements
>
> Not parsing the bitlength requirements comment, whatdoyoumean ?
The thing you mentioned in the commit message, it could also be a
hint in the code above the if-statement.
Konrad
next prev parent reply other threads:[~2023-08-22 19:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 16:16 [PATCH v1 0/9] media: qcom: camss: Bugfix series Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 1/9] media: qcom: camss: Fix pm_domain_on sequence in probe Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 2/9] media: qcom: camss: Fix V4L2 async notifier error path Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 3/9] media: qcom: camss: Fix vfe_get() error jump Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 4/9] media: qcom: camss: Fix VFE-17x vfe_disable_output() Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 5/9] media: qcom: camss: Fix VFE-480 vfe_disable_output() Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 6/9] media: qcom: camss: Fix missing vfe_lite clocks check Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 7/9] media: qcom: camss: Fix invalid clock enable bit disjunction Bryan O'Donoghue
2023-08-22 16:16 ` [PATCH v1 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3 Bryan O'Donoghue
2023-08-22 16:32 ` Konrad Dybcio
2023-08-22 19:03 ` Bryan O'Donoghue
2023-08-22 19:03 ` Konrad Dybcio [this message]
2023-08-22 16:16 ` [PATCH v1 9/9] media: qcom: camss: Fix csid-gen2 for test pattern generator Bryan O'Donoghue
2023-08-22 16:38 ` Konrad Dybcio
2023-08-22 19:07 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65c46da5-b03b-41cd-9030-8ebd7ae7b1e9@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®