* [PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl_table()
@ 2025-04-22 7:30 Chen Ni
2025-04-24 0:57 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2025-04-22 7:30 UTC (permalink / raw)
To: mark, jlbec, oseph.qi; +Cc: ocfs2-devel, linux-kernel, Chen Ni
unregister_sysctl_table() checks for NULL pointers internally.
Remove unneeded NULL check here.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
fs/ocfs2/stackglue.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
index ddd761cf44c8..a28c127b9934 100644
--- a/fs/ocfs2/stackglue.c
+++ b/fs/ocfs2/stackglue.c
@@ -691,8 +691,7 @@ static void __exit ocfs2_stack_glue_exit(void)
memset(&locking_max_version, 0,
sizeof(struct ocfs2_protocol_version));
ocfs2_sysfs_exit();
- if (ocfs2_table_header)
- unregister_sysctl_table(ocfs2_table_header);
+ unregister_sysctl_table(ocfs2_table_header);
}
MODULE_AUTHOR("Oracle");
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl_table()
2025-04-22 7:30 [PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
@ 2025-04-24 0:57 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2025-04-24 0:57 UTC (permalink / raw)
To: Chen Ni, mark, jlbec, akpm; +Cc: ocfs2-devel, linux-kernel
On 2025/4/22 15:30, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/stackglue.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index ddd761cf44c8..a28c127b9934 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -691,8 +691,7 @@ static void __exit ocfs2_stack_glue_exit(void)
> memset(&locking_max_version, 0,
> sizeof(struct ocfs2_protocol_version));
> ocfs2_sysfs_exit();
> - if (ocfs2_table_header)
> - unregister_sysctl_table(ocfs2_table_header);
> + unregister_sysctl_table(ocfs2_table_header);
> }
>
> MODULE_AUTHOR("Oracle");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-24 1:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-22 7:30 [PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
2025-04-24 0:57 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®