[PATCH v2] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[PATCH v2] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[Prabhakar]

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
Remove the duplicate entry to fix the following warning:

    arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2

Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2:
- Added "Fixes" tag.
---
 arch/arm64/configs/defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index e401915e2f2f..478ca72c0aeb 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1702,7 +1702,6 @@ CONFIG_PHY_UNIPHIER_USB3=y
 CONFIG_PHY_TEGRA_XUSB=y
 CONFIG_PHY_AM654_SERDES=m
 CONFIG_PHY_J721E_WIZ=m
-CONFIG_OMAP_USB2=m
 CONFIG_PHY_XILINX_ZYNQMP=m
 CONFIG_ARM_CCI_PMU=m
 CONFIG_ARM_CCN=m
-- 
2.43.0

Re: [PATCH v2] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[Geert Uytterhoeven]

On Wed, 15 Oct 2025 at 17:07, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
> Remove the duplicate entry to fix the following warning:
>
>     arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
>
> Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2:
> - Added "Fixes" tag.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

As this is not yet part of the soc tree, I guess it can still be fixed
in the original commit?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[Krzysztof Kozlowski]

On 15/10/2025 17:16, Geert Uytterhoeven wrote:
> On Wed, 15 Oct 2025 at 17:07, Prabhakar <prabhakar.csengg@gmail.com> wrote:
>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>
>> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
>> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
>> Remove the duplicate entry to fix the following warning:
>>
>>     arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
>>
>> Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>> v1->v2:
>> - Added "Fixes" tag.
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> As this is not yet part of the soc tree, I guess it can still be fixed
> in the original commit?

Yes.

And this should be somehow clearly indicated WHICH maintainer - Michal -
must do it. Or at least apply it.

Best regards,
Krzysztof

Re: [PATCH v2] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[Michal Simek]

On 10/16/25 07:48, Krzysztof Kozlowski wrote:
> On 15/10/2025 17:16, Geert Uytterhoeven wrote:
>> On Wed, 15 Oct 2025 at 17:07, Prabhakar <prabhakar.csengg@gmail.com> wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>
>>> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
>>> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
>>> Remove the duplicate entry to fix the following warning:
>>>
>>>      arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
>>>
>>> Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> ---
>>> v1->v2:
>>> - Added "Fixes" tag.
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> As this is not yet part of the soc tree, I guess it can still be fixed
>> in the original commit?
> 
> Yes.
> 
> And this should be somehow clearly indicated WHICH maintainer - Michal -
> must do it. Or at least apply it.

I was out yesterday. I have fixed it. It should be in Linux next tmr.

Thanks,
Michal

Re: [PATCH v2] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[Krzysztof Kozlowski]

On 16/10/2025 12:03, Michal Simek wrote:
> 
> 
> On 10/16/25 07:48, Krzysztof Kozlowski wrote:
>> On 15/10/2025 17:16, Geert Uytterhoeven wrote:
>>> On Wed, 15 Oct 2025 at 17:07, Prabhakar <prabhakar.csengg@gmail.com> wrote:
>>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>>
>>>> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
>>>> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
>>>> Remove the duplicate entry to fix the following warning:
>>>>
>>>>      arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
>>>>
>>>> Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")
>>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>> ---
>>>> v1->v2:
>>>> - Added "Fixes" tag.
>>>
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>
>>> As this is not yet part of the soc tree, I guess it can still be fixed
>>> in the original commit?
>>
>> Yes.
>>
>> And this should be somehow clearly indicated WHICH maintainer - Michal -
>> must do it. Or at least apply it.
> 
> I was out yesterday. I have fixed it. It should be in Linux next tmr.


Thanks, so the patch can be dropped.

Best regards,
Krzysztof