From: Joe Perches <joe@perches.com>
To: Petr Vorel <pvorel@suse.cz>, Simon Glass <sjg@chromium.org>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Tom Rini <trini@konsulko.com>,
Simon Glass <simon.glass@canonical.com>,
Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: Re: [PATCH v2] checkpatch: Allow to pass config directory
Date: Thu, 26 Mar 2026 17:06:32 -0700 [thread overview]
Message-ID: <65fe50aded2d9184bdb3198d0649e3eeb9bb3d18.camel@perches.com> (raw)
In-Reply-To: <20260326205020.GA23245@pevik>
On Thu, 2026-03-26 at 21:50 +0100, Petr Vorel wrote:
> > my $paths = $def_configuration_dirs;
> > $paths = "$ENV{$env_config_dir}:$paths" if exists($ENV{$env_config_dir});
>
> +1, sure, thanks!
Why have two uses of $ENV{$env_config_dir}?
Seems typo error prone and somewhat difficult to read.
next prev parent reply other threads:[~2026-03-27 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 18:16 Petr Vorel
2026-03-26 15:47 ` Petr Vorel
2026-03-26 17:48 ` Simon Glass
2026-03-26 20:50 ` Petr Vorel
2026-03-27 0:06 ` Joe Perches [this message]
2026-03-27 9:50 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65fe50aded2d9184bdb3198d0649e3eeb9bb3d18.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pvorel@suse.cz \
--cc=simon.glass@canonical.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®