mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yunfeng Ye <yeyunfeng@huawei.com>
To: <fweisbec@gmail.com>, <tglx@linutronix.de>, <mingo@kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Shiyuan Hu <hushiyuan@huawei.com>, Hewenliang <hewenliang4@huawei.com>
Subject: nohz: Update tick instead of restarting tick in tick_nohz_idle_exit()
Date: Mon, 23 Nov 2020 21:22:08 +0800	[thread overview]
Message-ID: <66014fea-7b84-358b-137d-d15190241528@huawei.com> (raw)

In realtime scenarios, the "nohz_full" parameter is configured. Tick
interference is not expected when there is only one realtime thread.
But when the idle thread is switched to the realtime thread, the tick
timer is restarted always.

So on the nohz full mode, it is unnecessary to restart the tick timer
when there is only one realtime thread. Adding can_stop_full_tick()
before restarting the tick, if it return true, keep tick stopped.

Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
 kernel/time/tick-sched.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index cc7cba20382e..f664c7735cab 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1208,6 +1208,20 @@ void tick_nohz_idle_restart_tick(void)
 		__tick_nohz_idle_restart_tick(ts, ktime_get());
 }

+static void tick_nohz_update_tick(struct tick_sched *ts, ktime_t now)
+{
+#ifdef CONFIG_NO_HZ_FULL
+	int cpu = smp_processor_id();
+
+	if (tick_nohz_full_cpu(cpu) && can_stop_full_tick(cpu, ts)) {
+		tick_nohz_stop_sched_tick(ts, cpu);
+		tick_nohz_account_idle_ticks(ts);
+		return;
+	}
+#endif
+	__tick_nohz_idle_restart_tick(ts, now);
+}
+
 /**
  * tick_nohz_idle_exit - restart the idle tick from the idle task
  *
@@ -1237,7 +1251,7 @@ void tick_nohz_idle_exit(void)
 		tick_nohz_stop_idle(ts, now);

 	if (tick_stopped)
-		__tick_nohz_idle_restart_tick(ts, now);
+		tick_nohz_update_tick(ts, now);

 	local_irq_enable();
 }
-- 
2.18.4

             reply	other threads:[~2020-11-23 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 13:22 Yunfeng Ye [this message]
2020-11-27 12:15 ` Frederic Weisbecker
2020-11-28  0:32   ` Yunfeng Ye
2021-02-19 12:16 ` Frederic Weisbecker
2021-02-19 13:08   ` Yunfeng Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66014fea-7b84-358b-137d-d15190241528@huawei.com \
    --to=yeyunfeng@huawei.com \
    --cc=fweisbec@gmail.com \
    --cc=hewenliang4@huawei.com \
    --cc=hushiyuan@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®