From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: <fweisbec@gmail.com>, <tglx@linutronix.de>, <mingo@kernel.org>,
<linux-kernel@vger.kernel.org>, Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: nohz: Update tick instead of restarting tick in tick_nohz_idle_exit()
Date: Sat, 28 Nov 2020 08:32:05 +0800 [thread overview]
Message-ID: <6d77dcc0-dea1-7b5e-9451-e4b21d7fb160@huawei.com> (raw)
In-Reply-To: <20201127121542.GA109224@lothringen>
On 2020/11/27 20:15, Frederic Weisbecker wrote:
> On Mon, Nov 23, 2020 at 09:22:08PM +0800, Yunfeng Ye wrote:
>> In realtime scenarios, the "nohz_full" parameter is configured. Tick
>> interference is not expected when there is only one realtime thread.
>> But when the idle thread is switched to the realtime thread, the tick
>> timer is restarted always.
>>
>> So on the nohz full mode, it is unnecessary to restart the tick timer
>> when there is only one realtime thread. Adding can_stop_full_tick()
>> before restarting the tick, if it return true, keep tick stopped.
>>
>> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
>
> We can indeed stop the tick and avoid it to be re-armed needlessly at this
> point.
>
> I'm taking your patch, I may just edit it a little and resend it.
>
Ok, thanks.
> Thanks!
> .
>
next prev parent reply other threads:[~2020-11-28 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 13:22 Yunfeng Ye
2020-11-27 12:15 ` Frederic Weisbecker
2020-11-28 0:32 ` Yunfeng Ye [this message]
2021-02-19 12:16 ` Frederic Weisbecker
2021-02-19 13:08 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d77dcc0-dea1-7b5e-9451-e4b21d7fb160@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=frederic@kernel.org \
--cc=fweisbec@gmail.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®