From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: dracoding <dracodingfly@gmail.com>,
davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, Fred Li <dracodingfly@gmail.com>
Subject: Re: [PATCH] net: Fix the gso BUG_ON that treat the skb which head_frag is true as non head_frag
Date: Thu, 16 May 2024 13:59:45 -0400 [thread overview]
Message-ID: <66464991ac8ea_54e932947a@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240515144313.61680-1-dracodingfly@gmail.com>
dracoding wrote:
> From: Fred Li <dracodingfly@gmail.com>
>
> The crashed kernel version is 5.16.20, and I have not test this patch
> because I dont find a way to reproduce it, and the mailine may be
> has the same problem.
That is a pretty old kernel.
There has been work in this space in the meantime. Such as commit
3dcbdb134f32 ("net: gso: Fix skb_segment splat when splitting gso_size
mangled skb having linear-headed frag_list") or commit 9e4b7a99a03a
("net: gso: fix panic on frag_list with mixed head alloc types").
WARNING: multiple messages have this Message-ID
From: Fred Li <dracodingfly@gmail.com>
To: dracoding@126.com, dracoding <dracodingfly@gmail.com>,
davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH] net: Fix the gso BUG_ON that treat the skb which head_frag is true as non head_frag
Date: Fri, 17 May 2024 21:51:40 +0800 [thread overview]
Message-ID: <66464991ac8ea_54e932947a@willemb.c.googlers.com.notmuch> (raw)
Message-ID: <20240517135140.fWhvLYFlCJxuVLrJfByyQI1qWBfAA1x-UoGP0fyCmf4@z> (raw)
In-Reply-To: <20240515144313.61680-1-dracodingfly@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> dracoding wrote:
> > From: Fred Li <dracodingfly@gmail.com>
> >
> > The crashed kernel version is 5.16.20, and I have not test this patch
> > because I dont find a way to reproduce it, and the mailine may be
> > has the same problem.
>
> That is a pretty old kernel.
>
> There has been work in this space in the meantime. Such as commit
> 3dcbdb134f32 ("net: gso: Fix skb_segment splat when splitting gso_size
> mangled skb having linear-headed frag_list") or commit 9e4b7a99a03a
> ("net: gso: fix panic on frag_list with mixed head alloc types").
The mainline kernel is using the commit 9e4b7a99a03a("net: gso: fix panic
on frag_list with mixed head alloc types") version, but it not work for me.
It disable NETIF_F_SG only if it has non head_frag skb.I will send a test
case which will cause the system crash, also in the kernel 6.6.8.
WARNING: multiple messages have this Message-ID
From: Fred Li <dracodingfly@gmail.com>
To: willemdebruijn.kernel@gmail.com,
dracoding <dracodingfly@gmail.com>,
davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: Fix the gso BUG_ON that treat the skb which head_frag is true as non head_frag
Date: Fri, 17 May 2024 22:02:51 +0800 [thread overview]
Message-ID: <66464991ac8ea_54e932947a@willemb.c.googlers.com.notmuch> (raw)
Message-ID: <20240517140251.6tixPqCB1fJKSee39ny3s0JkRUzLvz0atBp3H3BOgKw@z> (raw)
In-Reply-To: <20240515144313.61680-1-dracodingfly@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> dracoding wrote:
> > From: Fred Li <dracodingfly@gmail.com>
> >
> > The crashed kernel version is 5.16.20, and I have not test this patch
> > because I dont find a way to reproduce it, and the mailine may be
> > has the same problem.
>
> That is a pretty old kernel.
>
> There has been work in this space in the meantime. Such as commit
> 3dcbdb134f32 ("net: gso: Fix skb_segment splat when splitting gso_size
> mangled skb having linear-headed frag_list") or commit 9e4b7a99a03a
> ("net: gso: fix panic on frag_list with mixed head alloc types").
The mainline kernel is using the commit 9e4b7a99a03a("net: gso: fix panic
on frag_list with mixed head alloc types") version, but it not work for me.
It disable NETIF_F_SG only if it has non head_frag skb. This case is it has
only one head_frag frag_list skb. I will send a test case which will cause
the system crash, also in a newest kernel 6.6.8.
next prev parent reply other threads:[~2024-05-16 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 14:43 dracoding
2024-05-16 17:59 ` Willem de Bruijn [this message]
2024-05-17 13:51 ` Fred Li
2024-05-17 14:02 ` Fred Li
2024-05-17 15:40 ` [PATCH] test_bpf: Add an skb_segment test for a non linear frag_list whose head_frag=1 and gso_size was mangled Fred Li
2024-05-27 13:59 ` Fred Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66464991ac8ea_54e932947a@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dracodingfly@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®