mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] Add support for crypto v6 BAM
@ 2025-09-24 23:39 Jingyi Wang
  2025-09-24 23:39 ` [PATCH 1/2] dt-bindings: dma: qcom-bam: Document " Jingyi Wang
  2025-09-24 23:39 ` [PATCH 2/2] dmaengine: qcom: bam_dma: Add support for new crypto bam Jingyi Wang
  0 siblings, 2 replies; 4+ messages in thread
From: Jingyi Wang @ 2025-09-24 23:39 UTC (permalink / raw)
  To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, dmaengine, devicetree, linux-kernel, Jingyi Wang,
	aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, Gaurav Kashyap

Add document and driver for crypto BAM which is used by Qualcomm Crypto
Engine version 6 and above.

Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
Gaurav Kashyap (2):
      dt-bindings: dma: qcom-bam: Document crypto v6 BAM
      dmaengine: qcom: bam_dma: Add support for new crypto bam

 .../devicetree/bindings/dma/qcom,bam-dma.yaml      |  2 ++
 drivers/dma/qcom/bam_dma.c                         | 30 ++++++++++++++++++++++
 2 files changed, 32 insertions(+)
---
base-commit: ae2d20002576d2893ecaff25db3d7ef9190ac0b6
change-id: 20250922-knp-bam-c7e944a9b1c3

Best regards,
-- 
Jingyi Wang <jingyi.wang@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] dt-bindings: dma: qcom-bam: Document crypto v6 BAM
  2025-09-24 23:39 [PATCH 0/2] Add support for crypto v6 BAM Jingyi Wang
@ 2025-09-24 23:39 ` Jingyi Wang
  2025-11-05  9:58   ` Aiqun(Maria) Yu
  2025-09-24 23:39 ` [PATCH 2/2] dmaengine: qcom: bam_dma: Add support for new crypto bam Jingyi Wang
  1 sibling, 1 reply; 4+ messages in thread
From: Jingyi Wang @ 2025-09-24 23:39 UTC (permalink / raw)
  To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, dmaengine, devicetree, linux-kernel, Jingyi Wang,
	aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, Gaurav Kashyap

From: Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>

Document the new BAM compatible which is used by
QCE (Qualcomm Crypto Engine) versions 6 and above.

Signed-off-by: Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
index 6493a6968bb4..4e5b6675af7c 100644
--- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
@@ -17,6 +17,8 @@ properties:
   compatible:
     oneOf:
       - enum:
+          # Kaanapali
+          - qcom,bam-crypto-v6
           # APQ8064, IPQ8064 and MSM8960
           - qcom,bam-v1.3.0
           # MSM8974, APQ8074 and APQ8084

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] dmaengine: qcom: bam_dma: Add support for new crypto bam
  2025-09-24 23:39 [PATCH 0/2] Add support for crypto v6 BAM Jingyi Wang
  2025-09-24 23:39 ` [PATCH 1/2] dt-bindings: dma: qcom-bam: Document " Jingyi Wang
@ 2025-09-24 23:39 ` Jingyi Wang
  1 sibling, 0 replies; 4+ messages in thread
From: Jingyi Wang @ 2025-09-24 23:39 UTC (permalink / raw)
  To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, dmaengine, devicetree, linux-kernel, Jingyi Wang,
	aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, Gaurav Kashyap

From: Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>

A new revision of the crypto BAM called changes offsets
of the EE specific registers. Add support of this through
a new compatible string and register set.

Since a generic BAM module is deprecated and this new revision
is tied to crypto, naming it as such.

Signed-off-by: Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
 drivers/dma/qcom/bam_dma.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index 2cf060174795..06530e76ebc3 100644
--- a/drivers/dma/qcom/bam_dma.c
+++ b/drivers/dma/qcom/bam_dma.c
@@ -198,6 +198,35 @@ static const struct reg_offset_data bam_v1_7_reg_info[] = {
 	[BAM_P_FIFO_SIZES]	= { 0x13820, 0x00, 0x1000, 0x00 },
 };
 
+static const struct reg_offset_data bam_crypto_v6_reg_info[] = {
+	[BAM_CTRL]		= { 0x00000, 0x00, 0x00, 0x00 },
+	[BAM_REVISION]		= { 0x01000, 0x00, 0x00, 0x00 },
+	[BAM_NUM_PIPES]		= { 0x01008, 0x00, 0x00, 0x00 },
+	[BAM_DESC_CNT_TRSHLD]	= { 0x00008, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_SRCS]		= { 0x03010, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_SRCS_MSK]	= { 0x03014, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_SRCS_UNMASKED]	= { 0x03018, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_STTS]		= { 0x00014, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_CLR]		= { 0x00018, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_EN]		= { 0x0001C, 0x00, 0x00, 0x00 },
+	[BAM_CNFG_BITS]		= { 0x0007C, 0x00, 0x00, 0x00 },
+	[BAM_IRQ_SRCS_EE]	= { 0x03000, 0x00, 0x00, 0x1000 },
+	[BAM_IRQ_SRCS_MSK_EE]	= { 0x03004, 0x00, 0x00, 0x1000 },
+	[BAM_P_CTRL]		= { 0xC000, 0x1000, 0x00, 0x00 },
+	[BAM_P_RST]		= { 0xC004, 0x1000, 0x00, 0x00 },
+	[BAM_P_HALT]		= { 0xC008, 0x1000, 0x00, 0x00 },
+	[BAM_P_IRQ_STTS]	= { 0xC010, 0x1000, 0x00, 0x00 },
+	[BAM_P_IRQ_CLR]		= { 0xC014, 0x1000, 0x00, 0x00 },
+	[BAM_P_IRQ_EN]		= { 0xC018, 0x1000, 0x00, 0x00 },
+	[BAM_P_EVNT_DEST_ADDR]	= { 0xC82C, 0x00, 0x1000, 0x00 },
+	[BAM_P_EVNT_REG]	= { 0xC818, 0x00, 0x1000, 0x00 },
+	[BAM_P_SW_OFSTS]	= { 0xC800, 0x00, 0x1000, 0x00 },
+	[BAM_P_DATA_FIFO_ADDR]	= { 0xC824, 0x00, 0x1000, 0x00 },
+	[BAM_P_DESC_FIFO_ADDR]	= { 0xC81C, 0x00, 0x1000, 0x00 },
+	[BAM_P_EVNT_GEN_TRSHLD]	= { 0xC828, 0x00, 0x1000, 0x00 },
+	[BAM_P_FIFO_SIZES]	= { 0xC820, 0x00, 0x1000, 0x00 },
+};
+
 /* BAM CTRL */
 #define BAM_SW_RST			BIT(0)
 #define BAM_EN				BIT(1)
@@ -1228,6 +1257,7 @@ static const struct of_device_id bam_of_match[] = {
 	{ .compatible = "qcom,bam-v1.3.0", .data = &bam_v1_3_reg_info },
 	{ .compatible = "qcom,bam-v1.4.0", .data = &bam_v1_4_reg_info },
 	{ .compatible = "qcom,bam-v1.7.0", .data = &bam_v1_7_reg_info },
+	{ .compatible = "qcom,bam-crypto-v6", .data = &bam_crypto_v6_reg_info },
 	{}
 };
 

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] dt-bindings: dma: qcom-bam: Document crypto v6 BAM
  2025-09-24 23:39 ` [PATCH 1/2] dt-bindings: dma: qcom-bam: Document " Jingyi Wang
@ 2025-11-05  9:58   ` Aiqun(Maria) Yu
  0 siblings, 0 replies; 4+ messages in thread
From: Aiqun(Maria) Yu @ 2025-11-05  9:58 UTC (permalink / raw)
  To: Jingyi Wang, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, dmaengine, devicetree, linux-kernel,
	tingwei.zhang, trilok.soni, yijie.yang, Gaurav Kashyap

On 9/25/2025 7:39 AM, Jingyi Wang wrote:
> From: Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>
> 
> Document the new BAM compatible which is used by
> QCE (Qualcomm Crypto Engine) versions 6 and above.
> 
> Signed-off-by: Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> index 6493a6968bb4..4e5b6675af7c 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> @@ -17,6 +17,8 @@ properties:
>    compatible:
>      oneOf:
>        - enum:
> +          # Kaanapali
> +          - qcom,bam-crypto-v6

Is there a specific reason for changing the name format to include
“crypto” here?
It seems the previous format was something like qcom,bam-v6.0.0.
If we ever need to update to something like qcom,bam-v6.x.0, we wouldn’t
require a special renaming format just for bam-v6.

>            # APQ8064, IPQ8064 and MSM8960
>            - qcom,bam-v1.3.0
>            # MSM8974, APQ8074 and APQ8084
> 


-- 
Thx and BRs,
Aiqun(Maria) Yu

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-05  9:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-24 23:39 [PATCH 0/2] Add support for crypto v6 BAM Jingyi Wang
2025-09-24 23:39 ` [PATCH 1/2] dt-bindings: dma: qcom-bam: Document " Jingyi Wang
2025-11-05  9:58   ` Aiqun(Maria) Yu
2025-09-24 23:39 ` [PATCH 2/2] dmaengine: qcom: bam_dma: Add support for new crypto bam Jingyi Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®