* [PATCH] bcachefs: remove unneeded semicolon
@ 2024-04-15 2:35 Jiapeng Chong
2024-04-15 2:48 ` Hongbo Li
2024-04-15 2:55 ` Hongbo Li
0 siblings, 2 replies; 4+ messages in thread
From: Jiapeng Chong @ 2024-04-15 2:35 UTC (permalink / raw)
To: kent.overstreet
Cc: bfoster, linux-bcachefs, linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/bcachefs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 8daf80a38d60..234f19ea8f30 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
prt_bdevname(&buf, fs->bdev);
prt_char(&buf, ' ');
- bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
+ bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
prt_newline(&buf);
prt_bdevname(&buf, sb->bdev);
prt_char(&buf, ' ');
- bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
+ bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
prt_newline(&buf);
if (!opts->no_splitbrain_check)
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bcachefs: remove unneeded semicolon
2024-04-15 2:35 [PATCH] bcachefs: remove unneeded semicolon Jiapeng Chong
@ 2024-04-15 2:48 ` Hongbo Li
2024-04-15 2:55 ` Hongbo Li
1 sibling, 0 replies; 4+ messages in thread
From: Hongbo Li @ 2024-04-15 2:48 UTC (permalink / raw)
To: Jiapeng Chong, kent.overstreet
Cc: bfoster, linux-bcachefs, linux-kernel, Abaci Robot
Maybe it is not enough, you can use "grep -rn ');;' fs/bcachefs/" to
find out all the same format.
On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/bcachefs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>
> prt_bdevname(&buf, fs->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
> prt_newline(&buf);
>
> prt_bdevname(&buf, sb->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
> prt_newline(&buf);
>
> if (!opts->no_splitbrain_check)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bcachefs: remove unneeded semicolon
2024-04-15 2:35 [PATCH] bcachefs: remove unneeded semicolon Jiapeng Chong
2024-04-15 2:48 ` Hongbo Li
@ 2024-04-15 2:55 ` Hongbo Li
1 sibling, 0 replies; 4+ messages in thread
From: Hongbo Li @ 2024-04-15 2:55 UTC (permalink / raw)
To: Jiapeng Chong, kent.overstreet
Cc: bfoster, linux-bcachefs, linux-kernel, Abaci Robot
I remember other people also submit this likely patch:
https://lore.kernel.org/linux-bcachefs/20240103010720.39784-1-yang.lee@linux.alibaba.com/
https://lore.kernel.org/linux-bcachefs/20240103095942.3982021-1-lihongbo22@huawei.com/
On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/bcachefs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>
> prt_bdevname(&buf, fs->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
> prt_newline(&buf);
>
> prt_bdevname(&buf, sb->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
> prt_newline(&buf);
>
> if (!opts->no_splitbrain_check)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] bcachefs: Remove unneeded semicolon
@ 2024-07-01 3:27 Chen Ni
0 siblings, 0 replies; 4+ messages in thread
From: Chen Ni @ 2024-07-01 3:27 UTC (permalink / raw)
To: kent.overstreet; +Cc: linux-bcachefs, linux-kernel, Chen Ni
Remove unneeded semicolon.
This is detected by coccinelle.
Fixes: 0d529663f04b ("bcachefs: Split brain detection")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
fs/bcachefs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index bf7e998603f1..62dfaf60c131 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1116,12 +1116,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
prt_bdevname(&buf, fs->bdev);
prt_char(&buf, ' ');
- bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
+ bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
prt_newline(&buf);
prt_bdevname(&buf, sb->bdev);
prt_char(&buf, ' ');
- bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
+ bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
prt_newline(&buf);
if (!opts->no_splitbrain_check)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-01 3:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 2:35 [PATCH] bcachefs: remove unneeded semicolon Jiapeng Chong
2024-04-15 2:48 ` Hongbo Li
2024-04-15 2:55 ` Hongbo Li
2024-07-01 3:27 [PATCH] bcachefs: Remove " Chen Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®