[PATCH RESEND v5 0/5] HID: apple: combine patch series for all patches recently sent upstream

[PATCH RESEND v5 0/5] HID: apple: combine patch series for all patches recently sent upstream

[Aditya Garg]

From: Aditya Garg <gargaditya08@live.com>

Hi

This small patch series contains various pending patches for hid-apple in
a single series.

The first patch moves the backlight report structs, that were incorrectly
placed between the translation tables, to other related backlight structs.

The second patch makes use of switch case statements for the ever
increasing lengthy device table for fn translation.

The third patch removes the unused APPLE_IGNORE_MOUSE quirk.

The last 2 patches add Apple Magic Keyboard A3118 and A3119 USB-C support.

v2: Add A3118 Keyboard
v3: Add A3119 Keyboard
v4: The "from" email in patches authored by me was different from the one
I signed off using (thanks to outlook's weird oauth2 requirements).
Anyways, I've managed to get a workaround to get outlook working
finally, so sending them again properly.
v5: The cover letter itself failed to send in v4. Sending again.

Aditya Garg (4):
HID: apple: move backlight report structs to other backlight structs
HID: apple: use switch case to set fn translation table
HID: apple: remove unused APPLE_IGNORE_MOUSE quirk
HID: apple: Add Apple Magic Keyboard A3119 USB-C support

Grigorii Sokolik (1):
HID: apple: Add Apple Magic Keyboard A3118 USB-C support

drivers/hid/hid-apple.c | 126 +++++++++++++++++++++++-----------------
drivers/hid/hid-ids.h | 10 ++--
2 files changed, 78 insertions(+), 58 deletions(-)

-- 
2.43.0

[PATCH RESEND v5 1/5] HID: apple: move backlight report structs to other backlight structs

[Aditya Garg]

From: Aditya Garg <gargaditya08@live.com>

The apple_backlight_config_report and apple_backlight_set_report structs
were incorrectly placed between the translation tables. Fix this.

Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
drivers/hid/hid-apple.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index d900dd05c..93b990603 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -89,6 +89,19 @@ struct apple_sc_backlight {
struct hid_device *hdev;
};

+struct apple_backlight_config_report {
+ u8 report_id;
+ u8 version;
+ u16 backlight_off, backlight_on_min, backlight_on_max;
+};
+
+struct apple_backlight_set_report {
+ u8 report_id;
+ u8 version;
+ u16 backlight;
+ u16 rate;
+};
+
struct apple_magic_backlight {
struct led_classdev cdev;
struct hid_report *brightness;
@@ -152,20 +165,6 @@ static const struct apple_key_translation magic_keyboard_2015_fn_keys[] = {
{ }
};

-struct apple_backlight_config_report {
- u8 report_id;
- u8 version;
- u16 backlight_off, backlight_on_min, backlight_on_max;
-};
-
-struct apple_backlight_set_report {
- u8 report_id;
- u8 version;
- u16 backlight;
- u16 rate;
-};
-
-
static const struct apple_key_translation apple2021_fn_keys[] = {
{ KEY_BACKSPACE, KEY_DELETE },
{ KEY_ENTER, KEY_INSERT },
-- 
2.43.0

[PATCH RESEND v5 0/5] HID: apple: combine patch series for all patches recently sent upstream

[Aditya Garg]

Hi

This small patch series contains various pending patches for hid-apple in
a single series.

The first patch moves the backlight report structs, that were incorrectly
placed between the translation tables, to other related backlight structs.

The second patch makes use of switch case statements for the ever
increasing lengthy device table for fn translation.

The third patch removes the unused APPLE_IGNORE_MOUSE quirk.

The last 2 patches add Apple Magic Keyboard A3118 and A3119 USB-C support.

v2: Add A3118 Keyboard
v3: Add A3119 Keyboard
v4: The "from" email in patches authored by me was different from the one
    I signed off using (thanks to outlook's weird oauth2 requirements).
    Anyways, I've managed to get a workaround to get outlook working
    finally, so sending them again properly.
v5: The cover letter itself failed to send in v4. Sending again.

Aditya Garg (4):
  HID: apple: move backlight report structs to other backlight structs
  HID: apple: use switch case to set fn translation table
  HID: apple: remove unused APPLE_IGNORE_MOUSE quirk
  HID: apple: Add Apple Magic Keyboard A3119 USB-C support

Grigorii Sokolik (1):
  HID: apple: Add Apple Magic Keyboard A3118 USB-C support

 drivers/hid/hid-apple.c | 126 +++++++++++++++++++++++-----------------
 drivers/hid/hid-ids.h   |  10 ++--
 2 files changed, 78 insertions(+), 58 deletions(-)

-- 
2.49.0

[PATCH RESEND v5 0/5] HID: apple: combine patch series for all patches recently sent upstream

[Aditya Garg]

From: Aditya Garg <gargaditya08@live.com>

Hi

This small patch series contains various pending patches for hid-apple in
a single series.

The first patch moves the backlight report structs, that were incorrectly
placed between the translation tables, to other related backlight structs.

The second patch makes use of switch case statements for the ever
increasing lengthy device table for fn translation.

The third patch removes the unused APPLE_IGNORE_MOUSE quirk.

The last 2 patches add Apple Magic Keyboard A3118 and A3119 USB-C support.

v2: Add A3118 Keyboard
v3: Add A3119 Keyboard
v4: The "from" email in patches authored by me was different from the one
I signed off using (thanks to outlook's weird oauth2 requirements).
Anyways, I've managed to get a workaround to get outlook working
finally, so sending them again properly.
v5: The cover letter itself failed to send in v4. Sending again.

Aditya Garg (4):
  HID: apple: move backlight report structs to other backlight structs
  HID: apple: use switch case to set fn translation table
  HID: apple: remove unused APPLE_IGNORE_MOUSE quirk
  HID: apple: Add Apple Magic Keyboard A3119 USB-C support

Grigorii Sokolik (1):
  HID: apple: Add Apple Magic Keyboard A3118 USB-C support

 drivers/hid/hid-apple.c | 126 +++++++++++++++++++++++-----------------
 drivers/hid/hid-ids.h   |  10 ++--
 2 files changed, 78 insertions(+), 58 deletions(-)

-- 
2.49.0