* [PATCH]8390p: Get rid of init_module/cleanup_module
@ 2009-04-11 12:55 Mateusz Mandera
2009-04-20 15:46 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Mateusz Mandera @ 2009-04-11 12:55 UTC (permalink / raw)
To: linux-kernel, kernel-janitors, p_gortmaker, trivial
This trivial patch just "gets rid of" init_module and cleanup_module
from drivers/net/8390p.c
Signed-off-by: Mateusz Mandera <ormi.linux@gmail.com>
---
diff --git a/drivers/net/8390p.c b/drivers/net/8390p.c
index da863c9..ec9e3ca 100644
--- a/drivers/net/8390p.c
+++ b/drivers/net/8390p.c
@@ -97,16 +97,15 @@ void NS8390p_init(struct net_device *dev, int startp)
}
EXPORT_SYMBOL(NS8390p_init);
-#if defined(MODULE)
-
-int init_module(void)
+static int __init 8390p_init_module(void)
{
return 0;
}
-void cleanup_module(void)
+static void __exit 8390p_cleanup_module(void)
{
}
-#endif /* MODULE */
+module_init(8390p_init_module);
+module_exit(8390p_cleanup_module);
MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH]8390p: Get rid of init_module/cleanup_module
2009-04-11 12:55 [PATCH]8390p: Get rid of init_module/cleanup_module Mateusz Mandera
@ 2009-04-20 15:46 ` Jiri Kosina
2009-04-22 9:24 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2009-04-20 15:46 UTC (permalink / raw)
To: Mateusz Mandera
Cc: linux-kernel, kernel-janitors, p_gortmaker, trivial, netdev
On Sat, 11 Apr 2009, Mateusz Mandera wrote:
> This trivial patch just "gets rid of" init_module and cleanup_module
> from drivers/net/8390p.c
>
> Signed-off-by: Mateusz Mandera <ormi.linux@gmail.com>
> ---
> diff --git a/drivers/net/8390p.c b/drivers/net/8390p.c
> index da863c9..ec9e3ca 100644
> --- a/drivers/net/8390p.c
> +++ b/drivers/net/8390p.c
> @@ -97,16 +97,15 @@ void NS8390p_init(struct net_device *dev, int startp)
> }
> EXPORT_SYMBOL(NS8390p_init);
>
> -#if defined(MODULE)
> -
> -int init_module(void)
> +static int __init 8390p_init_module(void)
> {
> return 0;
> }
>
> -void cleanup_module(void)
> +static void __exit 8390p_cleanup_module(void)
> {
> }
>
> -#endif /* MODULE */
> +module_init(8390p_init_module);
> +module_exit(8390p_cleanup_module);
> MODULE_LICENSE("GPL");
I'd rather have this merged through subsystem tree than trivial tree,
adding netdev to CC.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH]8390p: Get rid of init_module/cleanup_module
2009-04-20 15:46 ` Jiri Kosina
@ 2009-04-22 9:24 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-04-22 9:24 UTC (permalink / raw)
To: jkosina
Cc: ormi.linux, linux-kernel, kernel-janitors, p_gortmaker, trivial, netdev
From: Jiri Kosina <jkosina@suse.cz>
Date: Mon, 20 Apr 2009 17:46:19 +0200 (CEST)
> On Sat, 11 Apr 2009, Mateusz Mandera wrote:
>
>> This trivial patch just "gets rid of" init_module and cleanup_module
>> from drivers/net/8390p.c
>>
>> Signed-off-by: Mateusz Mandera <ormi.linux@gmail.com>
...
> I'd rather have this merged through subsystem tree than trivial tree,
> adding netdev to CC.
Applied to net-next-2.6, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-22 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-11 12:55 [PATCH]8390p: Get rid of init_module/cleanup_module Mateusz Mandera
2009-04-20 15:46 ` Jiri Kosina
2009-04-22 9:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®