From: "Kuehling, Felix" <felix.kuehling@amd.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: yunbolyu@smu.edu.sg, kexinsun@smail.nju.edu.cn,
ratnadiraw@smu.edu.sg, xutong.ma@inria.fr,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: update outdated comment
Date: Fri, 2 Jan 2026 17:46:52 -0500 [thread overview]
Message-ID: <668b84cf-2435-4695-a192-c6c2b89737a6@amd.com> (raw)
In-Reply-To: <20251230175353.105289-1-Julia.Lawall@inria.fr>
On 2025-12-30 12:53, Julia Lawall wrote:
> The function amdgpu_amdkfd_gpuvm_import_dmabuf() was split into
> import_obj_create() and amdgpu_amdkfd_gpuvm_import_dmabuf_fd() in
> commit 0188006d7c79 ("drm/amdkfd: Import DMABufs for interop
> through DRM"). import_obj_create() now does the allocation for
> the mem variable discussed in the comment.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
for this and your other amdkfd patch. I submitted them to
amd-staging-drm-next.
Thanks,
Felix
>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index b1c24c8fa686..4782265d5e91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1987,7 +1987,8 @@ int amdgpu_amdkfd_gpuvm_free_memory_of_gpu(
> drm_gem_object_put(&mem->bo->tbo.base);
>
> /*
> - * For kgd_mem allocated in amdgpu_amdkfd_gpuvm_import_dmabuf(),
> + * For kgd_mem allocated in import_obj_create() via
> + * amdgpu_amdkfd_gpuvm_import_dmabuf_fd(),
> * explicitly free it here.
> */
> if (!use_release_notifier)
>
prev parent reply other threads:[~2026-01-02 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 17:53 Julia Lawall
2026-01-02 22:46 ` Kuehling, Felix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=668b84cf-2435-4695-a192-c6c2b89737a6@amd.com \
--to=felix.kuehling@amd.com \
--cc=Julia.Lawall@inria.fr \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kexinsun@smail.nju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=ratnadiraw@smu.edu.sg \
--cc=simona@ffwll.ch \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®