* [PATCH] drm/amdgpu: update outdated comment
@ 2025-12-30 17:53 Julia Lawall
2026-01-02 22:46 ` Kuehling, Felix
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2025-12-30 17:53 UTC (permalink / raw)
To: Felix Kuehling
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Alex Deucher,
Christian König, David Airlie, Simona Vetter, amd-gfx,
dri-devel, linux-kernel
The function amdgpu_amdkfd_gpuvm_import_dmabuf() was split into
import_obj_create() and amdgpu_amdkfd_gpuvm_import_dmabuf_fd() in
commit 0188006d7c79 ("drm/amdkfd: Import DMABufs for interop
through DRM"). import_obj_create() now does the allocation for
the mem variable discussed in the comment.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index b1c24c8fa686..4782265d5e91 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1987,7 +1987,8 @@ int amdgpu_amdkfd_gpuvm_free_memory_of_gpu(
drm_gem_object_put(&mem->bo->tbo.base);
/*
- * For kgd_mem allocated in amdgpu_amdkfd_gpuvm_import_dmabuf(),
+ * For kgd_mem allocated in import_obj_create() via
+ * amdgpu_amdkfd_gpuvm_import_dmabuf_fd(),
* explicitly free it here.
*/
if (!use_release_notifier)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amdgpu: update outdated comment
2025-12-30 17:53 [PATCH] drm/amdgpu: update outdated comment Julia Lawall
@ 2026-01-02 22:46 ` Kuehling, Felix
0 siblings, 0 replies; 2+ messages in thread
From: Kuehling, Felix @ 2026-01-02 22:46 UTC (permalink / raw)
To: Julia Lawall
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Alex Deucher,
Christian König, David Airlie, Simona Vetter, amd-gfx,
dri-devel, linux-kernel
On 2025-12-30 12:53, Julia Lawall wrote:
> The function amdgpu_amdkfd_gpuvm_import_dmabuf() was split into
> import_obj_create() and amdgpu_amdkfd_gpuvm_import_dmabuf_fd() in
> commit 0188006d7c79 ("drm/amdkfd: Import DMABufs for interop
> through DRM"). import_obj_create() now does the allocation for
> the mem variable discussed in the comment.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
for this and your other amdkfd patch. I submitted them to
amd-staging-drm-next.
Thanks,
Felix
>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index b1c24c8fa686..4782265d5e91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1987,7 +1987,8 @@ int amdgpu_amdkfd_gpuvm_free_memory_of_gpu(
> drm_gem_object_put(&mem->bo->tbo.base);
>
> /*
> - * For kgd_mem allocated in amdgpu_amdkfd_gpuvm_import_dmabuf(),
> + * For kgd_mem allocated in import_obj_create() via
> + * amdgpu_amdkfd_gpuvm_import_dmabuf_fd(),
> * explicitly free it here.
> */
> if (!use_release_notifier)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-02 22:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-30 17:53 [PATCH] drm/amdgpu: update outdated comment Julia Lawall
2026-01-02 22:46 ` Kuehling, Felix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®