[PATCH] mailbox: zynqmp: setup IPI for each valid child node

[PATCH] mailbox: zynqmp: setup IPI for each valid child node

[Tanmay Shah]

As per zynqmp-ipi bindings, zynqmp IPI node can have multiple child nodes.
Current IPI setup function is set only for first child node. If IPI node
has multiple child nodes in the device-tree, then IPI setup fails for
child nodes other than first child node. In such case kernel will crash.
Fix this crash by registering IPI setup function for each available child
node.

Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
 drivers/mailbox/zynqmp-ipi-mailbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index 521d08b9ab47..815e0492f029 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -940,10 +940,10 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
 	pdata->num_mboxes = num_mboxes;
 
 	mbox = pdata->ipi_mboxes;
-	mbox->setup_ipi_fn = ipi_fn;
-
 	for_each_available_child_of_node(np, nc) {
 		mbox->pdata = pdata;
+		mbox->setup_ipi_fn = ipi_fn;
+
 		ret = zynqmp_ipi_mbox_probe(mbox, nc);
 		if (ret) {
 			of_node_put(nc);

base-commit: 28955f4fa2823e39f1ecfb3a37a364563527afbc
-- 
2.34.1

Re: [PATCH] mailbox: zynqmp: setup IPI for each valid child node

[Michal Simek]

On 11/12/24 18:06, Tanmay Shah wrote:
> As per zynqmp-ipi bindings, zynqmp IPI node can have multiple child nodes.
> Current IPI setup function is set only for first child node. If IPI node
> has multiple child nodes in the device-tree, then IPI setup fails for
> child nodes other than first child node. In such case kernel will crash.
> Fix this crash by registering IPI setup function for each available child
> node.
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>   drivers/mailbox/zynqmp-ipi-mailbox.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 521d08b9ab47..815e0492f029 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -940,10 +940,10 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>   	pdata->num_mboxes = num_mboxes;
>   
>   	mbox = pdata->ipi_mboxes;
> -	mbox->setup_ipi_fn = ipi_fn;
> -
>   	for_each_available_child_of_node(np, nc) {
>   		mbox->pdata = pdata;
> +		mbox->setup_ipi_fn = ipi_fn;
> +
>   		ret = zynqmp_ipi_mbox_probe(mbox, nc);
>   		if (ret) {
>   			of_node_put(nc);
> 
> base-commit: 28955f4fa2823e39f1ecfb3a37a364563527afbc

I think you should add Fixed tag and also cc stable@kernel.org

With that fixed feel free to add
Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal