* [PATCH] media: i2c: adv748x: fix HDMI field heights
@ 2018-01-08 17:39 Kieran Bingham
2018-01-08 17:56 ` Niklas Söderlund
0 siblings, 1 reply; 3+ messages in thread
From: Kieran Bingham @ 2018-01-08 17:39 UTC (permalink / raw)
To: linux-media, linux-renesas-soc
Cc: Hans Verkuil, niklas.soderlund, Kieran Bingham, Kieran Bingham,
Mauro Carvalho Chehab, open list
The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field
types. The correct specification for the height on the mbus is the
image height, in this instance, the field height.
The AFE component already correctly adjusts the height on the mbus, but
the HDMI component got left behind.
Adjust the mbus height to correctly describe the image height of the
fields when processing interlaced video for HDMI pipelines.
Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
drivers/media/i2c/adv748x/adv748x-hdmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c
index 4da4253553fc..0e2f76f3f029 100644
--- a/drivers/media/i2c/adv748x/adv748x-hdmi.c
+++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c
@@ -105,6 +105,10 @@ static void adv748x_hdmi_fill_format(struct adv748x_hdmi *hdmi,
fmt->width = hdmi->timings.bt.width;
fmt->height = hdmi->timings.bt.height;
+
+ /* Propagate field height on the mbus for FIELD_ALTERNATE fmts */
+ if (hdmi->timings.bt.interlaced)
+ fmt->height /= 2;
}
static void adv748x_fill_optional_dv_timings(struct v4l2_dv_timings *timings)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: adv748x: fix HDMI field heights
2018-01-08 17:39 [PATCH] media: i2c: adv748x: fix HDMI field heights Kieran Bingham
@ 2018-01-08 17:56 ` Niklas Söderlund
2018-01-08 18:05 ` Kieran Bingham
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Söderlund @ 2018-01-08 17:56 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-media, linux-renesas-soc, Hans Verkuil, Kieran Bingham,
Mauro Carvalho Chehab, open list
Hi Kieran,
Thanks for your patch.
On 2018-01-08 17:39:30 +0000, Kieran Bingham wrote:
> The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field
> types. The correct specification for the height on the mbus is the
> image height, in this instance, the field height.
>
> The AFE component already correctly adjusts the height on the mbus, but
> the HDMI component got left behind.
>
> Adjust the mbus height to correctly describe the image height of the
> fields when processing interlaced video for HDMI pipelines.
>
> Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/i2c/adv748x/adv748x-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c
> index 4da4253553fc..0e2f76f3f029 100644
> --- a/drivers/media/i2c/adv748x/adv748x-hdmi.c
> +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c
> @@ -105,6 +105,10 @@ static void adv748x_hdmi_fill_format(struct adv748x_hdmi *hdmi,
>
> fmt->width = hdmi->timings.bt.width;
> fmt->height = hdmi->timings.bt.height;
> +
> + /* Propagate field height on the mbus for FIELD_ALTERNATE fmts */
> + if (hdmi->timings.bt.interlaced)
if (V4L2_FIELD_HAS_T_OR_B(fmt->field))
Nit-picking but I would use the field here (which is set just above this
in the same function) as it makes it more clear why the format is cut in
half. I looked at the documentation for bt.interlaced and I'm not sure
if it would be set to true for INTERLACED field formats when the height
should not be halved? In this case it do not matter as
fmt->field = hdmi->timings.bt.interlaced ?
V4L2_FIELD_ALTERNATE : V4L2_FIELD_NONE;
So I leave this up to you and feel free to add in either case.
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> + fmt->height /= 2;
> }
>
> static void adv748x_fill_optional_dv_timings(struct v4l2_dv_timings *timings)
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: i2c: adv748x: fix HDMI field heights
2018-01-08 17:56 ` Niklas Söderlund
@ 2018-01-08 18:05 ` Kieran Bingham
0 siblings, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2018-01-08 18:05 UTC (permalink / raw)
To: Niklas Söderlund
Cc: linux-media, linux-renesas-soc, Hans Verkuil, Kieran Bingham,
Mauro Carvalho Chehab, open list
Hi Niklas,
On 08/01/18 17:56, Niklas Söderlund wrote:
> Hi Kieran,
>
> Thanks for your patch.
>
> On 2018-01-08 17:39:30 +0000, Kieran Bingham wrote:
>> The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field
>> types. The correct specification for the height on the mbus is the
>> image height, in this instance, the field height.
>>
>> The AFE component already correctly adjusts the height on the mbus, but
>> the HDMI component got left behind.
>>
>> Adjust the mbus height to correctly describe the image height of the
>> fields when processing interlaced video for HDMI pipelines.
>>
>> Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> ---
>> drivers/media/i2c/adv748x/adv748x-hdmi.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c
>> index 4da4253553fc..0e2f76f3f029 100644
>> --- a/drivers/media/i2c/adv748x/adv748x-hdmi.c
>> +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c
>> @@ -105,6 +105,10 @@ static void adv748x_hdmi_fill_format(struct adv748x_hdmi *hdmi,
>>
>> fmt->width = hdmi->timings.bt.width;
>> fmt->height = hdmi->timings.bt.height;
>> +
>> + /* Propagate field height on the mbus for FIELD_ALTERNATE fmts */
>> + if (hdmi->timings.bt.interlaced)
>
> if (V4L2_FIELD_HAS_T_OR_B(fmt->field))
>
> Nit-picking but I would use the field here (which is set just above this
> in the same function) as it makes it more clear why the format is cut in
> half. I looked at the documentation for bt.interlaced and I'm not sure
> if it would be set to true for INTERLACED field formats when the height
> should not be halved? In this case it do not matter as
>
> fmt->field = hdmi->timings.bt.interlaced ?
> V4L2_FIELD_ALTERNATE : V4L2_FIELD_NONE;
>
> So I leave this up to you and feel free to add in either case.
In this instance, I chose to mirror the value(/code path) which explicitly sets
the V4L2_FIELD_ALTERNATE, rather than:
if (fmt->field == V4L2_FIELD_ALTERNATE ||
fmt->field == V4L2_FIELD_TOP ||
fmt->field == V4L2_FIELD_BOTTOM)
But perhaps we would never expect _TOP || _BOTTOM therefore
if (fmt->field == V4L2_FIELD_ALTERNATE)
might be perfectly suitable?
Actually - yes - I now agree. I'll respin.
--
Kieran
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
>> + fmt->height /= 2;
>> }
>>
>> static void adv748x_fill_optional_dv_timings(struct v4l2_dv_timings *timings)
>> --
>> 2.7.4
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-08 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-08 17:39 [PATCH] media: i2c: adv748x: fix HDMI field heights Kieran Bingham
2018-01-08 17:56 ` Niklas Söderlund
2018-01-08 18:05 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®