Re: [PATCH v2] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()

Re: [PATCH v2] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()

[Damien Le Moal]

On 7/19/23 18:49, 杜敏杰 wrote:
> It is possible for dma_request_chan() to return EPROBE_DEFER, which means
> acdev->host->dev is not ready yet.
> At this point dev_err() will have no output.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/ata/pata_arasan_cf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 6ab294322..fd54682f1 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
>  	/* dma_request_channel may sleep, so calling from process context */
>  	acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
>  	if (IS_ERR(acdev->dma_chan)) {
> -		dev_err(acdev->host->dev, "Unable to get dma_chan\n");
> +		dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
> +					  "Unable to get dma_chan\n");

Still not aligned...

        dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
                      "Unable to get dma_chan\n");

Like this please.

>  		acdev->dma_chan = NULL;
>  		goto chan_request_fail;
>  	}

-- 
Damien Le Moal
Western Digital Research