* [PATCH] platform/x86: dell-laptop: unregister notifier on init failure
@ 2026-06-03 6:38 Haoxiang Li
2026-06-08 10:14 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2026-06-03 6:38 UTC (permalink / raw)
To: mjg59, ali, hansg, ilpo.jarvinen
Cc: platform-driver-x86, linux-kernel, Haoxiang Li
Add the missing dell_laptop_unregister_notifier() call to the
failure path after notifier registration.
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
drivers/platform/x86/dell/dell-laptop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c
index 57748c3ea24f..5dd607e8d2ab 100644
--- a/drivers/platform/x86/dell/dell-laptop.c
+++ b/drivers/platform/x86/dell/dell-laptop.c
@@ -2551,6 +2551,7 @@ static int __init dell_init(void)
if (mute_led_registered)
led_classdev_unregister(&mute_led_cdev);
fail_led:
+ dell_laptop_unregister_notifier(&dell_laptop_notifier);
dell_battery_exit();
dell_cleanup_rfkill();
fail_rfkill:
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: dell-laptop: unregister notifier on init failure
2026-06-03 6:38 [PATCH] platform/x86: dell-laptop: unregister notifier on init failure Haoxiang Li
@ 2026-06-08 10:14 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2026-06-08 10:14 UTC (permalink / raw)
To: Haoxiang Li; +Cc: mjg59, ali, Hans de Goede, platform-driver-x86, LKML
On Wed, 3 Jun 2026, Haoxiang Li wrote:
> Add the missing dell_laptop_unregister_notifier() call to the
> failure path after notifier registration.
>
Missing a Fixes tag?
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
> ---
> drivers/platform/x86/dell/dell-laptop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c
> index 57748c3ea24f..5dd607e8d2ab 100644
> --- a/drivers/platform/x86/dell/dell-laptop.c
> +++ b/drivers/platform/x86/dell/dell-laptop.c
> @@ -2551,6 +2551,7 @@ static int __init dell_init(void)
> if (mute_led_registered)
> led_classdev_unregister(&mute_led_cdev);
> fail_led:
> + dell_laptop_unregister_notifier(&dell_laptop_notifier);
Unfortunately, this doesn't look like to be the only problem here.
> dell_battery_exit();
> dell_cleanup_rfkill();
> fail_rfkill:
>
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-08 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-03 6:38 [PATCH] platform/x86: dell-laptop: unregister notifier on init failure Haoxiang Li
2026-06-08 10:14 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®