mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Raghavendra K T <raghavendra.kt@amd.com>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Cc: <bharata@amd.com>, Raghavendra K T <raghavendra.kt@amd.com>,
	Huang Ying <ying.huang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	David Hildenbrand <david@redhat.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	"Alison Schofield" <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Alistair Popple <apopple@nvidia.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>, Baoquan He <bhe@redhat.com>,
	<ilpo.jarvinen@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Fontenot Nathan <Nathan.Fontenot@amd.com>,
	Wei Huang <wei.huang2@amd.com>, <regressions@lists.linux.dev>
Subject: Re: [RFC PATCH] resource: Fix CXL node not populated issue
Date: Tue, 3 Dec 2024 19:55:32 -0800	[thread overview]
Message-ID: <674fd2b4942f1_3e0f629420@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20241202111941.2636613-1-raghavendra.kt@amd.com>

[ add regressions@lists.linux.dev ]

Next time make the subject of the patch:

   Revert "resource: fix region_intersects() vs add_memory_driver_managed()"

...to make it clear that this is a revert, not a fix.

The revert should be applied if a fix does not materialize in the next few weeks.

Raghavendra K T wrote:
> Before:
> ~]$ numastat -m
> ...
>                           Node 0          Node 1           Total
>                  --------------- --------------- ---------------
> MemTotal               128096.18       128838.48       256934.65
> 
> After:
> $ numastat -m
> .....
>                           Node 0          Node 1          Node 2           Total
>                  --------------- --------------- --------------- ---------------
> MemTotal               128054.16       128880.51       129024.00       385958.67
> 
> Current patch reverts the effect of first commit where the issue is seen.

Might you be able to dig a bit further into the details like memory map
for this platform and ACPI SRAT tables? A dmesg comparison of the good
and bad cases would be useful (those can be shared via a github gist).
Even better would be some debug instrumentation to identify which call
to __region_intersects() started behaving differently resulting in a
whole node disappearing.

In terms of the urgency of fixing this it would also help to know how
prevalent the system this was found on is in the wild.

  parent reply	other threads:[~2024-12-04  3:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 11:19 Raghavendra K T
2024-12-02 15:34 ` Andy Shevchenko
2024-12-03  6:01   ` Raghavendra K T
2024-12-03  6:26 ` Huang, Ying
2024-12-03 13:41   ` Andy Shevchenko
     [not found]     ` <CAAt7c_piFt2UY_OSzdhhr3yFfgMZPgcw2ogtAoVRjgDFGaG_8Q@mail.gmail.com>
2024-12-03 22:07       ` Andy Shevchenko
2024-12-04  2:07     ` Huang, Ying
2024-12-04  3:01       ` Andy Shevchenko
2024-12-04  4:44         ` Raghavendra K T
2024-12-05  5:45           ` Raghavendra K T
2024-12-04  3:55 ` Dan Williams [this message]
2024-12-04  4:41   ` Raghavendra K T
2024-12-06  7:50     ` Dan Williams
2024-12-06  8:28       ` Raghavendra K T
2024-12-11  4:44         ` Dan Williams
2024-12-11  6:40           ` Bharata B Rao
2024-12-11  8:38             ` Dan Williams
2024-12-11 16:47               ` Bharata B Rao
2024-12-12  1:02                 ` Raghavendra K T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=674fd2b4942f1_3e0f629420@dwillia2-mobl3.amr.corp.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Nathan.Fontenot@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=alison.schofield@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apopple@nvidia.com \
    --cc=bharata@amd.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=raghavendra.kt@amd.com \
    --cc=regressions@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    --cc=wei.huang2@amd.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®