mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Raghavendra K T <raghavendra.kt@amd.com>,
	Dan Williams <dan.j.williams@intel.com>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Cc: <bharata@amd.com>, Huang Ying <ying.huang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	Alistair Popple <apopple@nvidia.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>, Baoquan He <bhe@redhat.com>,
	<ilpo.jarvinen@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Fontenot Nathan <Nathan.Fontenot@amd.com>,
	Wei Huang <wei.huang2@amd.com>, <regressions@lists.linux.dev>
Subject: Re: [RFC PATCH] resource: Fix CXL node not populated issue
Date: Tue, 10 Dec 2024 20:44:36 -0800	[thread overview]
Message-ID: <675918b414c17_10a0832943b@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <2b5bb8d8-6a7d-4a58-bde7-ce42d0a23f61@amd.com>

Raghavendra K T wrote:
> 
> 
> On 12/6/2024 1:20 PM, Dan Williams wrote:
> > Raghavendra K T wrote:
> >>
> [...]
> >> B. /proc/iomem
> >>
> >> $ vimdiff success fail
> >>
> >>    4050000000-604fffffff : Soft Reserved
> >>     |  164 4050000000-604fffffff : Soft Reserved
> >>     165   4050000000-604fffffff : CXL Window 0
> >>          |  165   4050000000-604fffffff : CXL Window 0
> >>     166     4080000000-5fffffffff : dax1.0
> >>          |
> >> ------------------------------------------------------------------------
> >>     167       4080000000-5fffffffff : System RAM (kmem)
> >>          |
> >> --------------------------------------------------------------------
> > 
> > My eyes only know how to read unified diff (diff -u) format. Is this
> > saying that in the failure case the System RAM range for dax1.0 is
> > missing?
> 
> 
> Sorry for that formatting. I realized later.
> Yes. dax1.0 missing in the failure case.
> 
> Looks like problem is that,
> 
> 4050000000-604fffffff : Soft Reserved
>    4050000000-604fffffff : CXL Window 0
>       4080000000-5fffffffff : dax1.0
>          4080000000-5fffffffff : System RAM (kmem)
> 
> this use case where,
> 
> |A<------------->D|  CXL window
> |..|B<-->C|.......|    kmem
> 
> B->C range that falls within A->D as in above somehow
> not covered after the patch.

I was able to reproduce a similar set of conditions with the cxl_test
environment:

f010000000-f04fffffff : Soft Reserved
  f010000000-f04fffffff : CXL Window 0
    f020000000-f03fffffff : region3
      f020000000-f03fffffff : dax3.0
        f020000000-f03fffffff : System RAM (kmem)


...but that did not result in the bug. So there are some other details
missing. Can you proceed with providing the dmesg from the good and the
bad cases?

gist.github.com is useful for this.

  reply	other threads:[~2024-12-11  4:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 11:19 Raghavendra K T
2024-12-02 15:34 ` Andy Shevchenko
2024-12-03  6:01   ` Raghavendra K T
2024-12-03  6:26 ` Huang, Ying
2024-12-03 13:41   ` Andy Shevchenko
     [not found]     ` <CAAt7c_piFt2UY_OSzdhhr3yFfgMZPgcw2ogtAoVRjgDFGaG_8Q@mail.gmail.com>
2024-12-03 22:07       ` Andy Shevchenko
2024-12-04  2:07     ` Huang, Ying
2024-12-04  3:01       ` Andy Shevchenko
2024-12-04  4:44         ` Raghavendra K T
2024-12-05  5:45           ` Raghavendra K T
2024-12-04  3:55 ` Dan Williams
2024-12-04  4:41   ` Raghavendra K T
2024-12-06  7:50     ` Dan Williams
2024-12-06  8:28       ` Raghavendra K T
2024-12-11  4:44         ` Dan Williams [this message]
2024-12-11  6:40           ` Bharata B Rao
2024-12-11  8:38             ` Dan Williams
2024-12-11 16:47               ` Bharata B Rao
2024-12-12  1:02                 ` Raghavendra K T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=675918b414c17_10a0832943b@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Nathan.Fontenot@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=alison.schofield@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apopple@nvidia.com \
    --cc=bharata@amd.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=raghavendra.kt@amd.com \
    --cc=regressions@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    --cc=wei.huang2@amd.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®