mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Amit Shah <amit@kernel.org>
To: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-kernel@vger.kernel.org,  virtualization@lists.linux.dev
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
	brueckner@linux.ibm.com,  pasic@linux.ibm.com
Subject: Re: [PATCH] virtio: console: Make resizing compliant with virtio spec
Date: Tue, 18 Mar 2025 10:51:58 +0100	[thread overview]
Message-ID: <6760518ea9e65ec5d1a18861f88e0a758e0f3fa6.camel@kernel.org> (raw)
In-Reply-To: <62008b201c5a64df28c0039020d9bd7959744014.camel@linux.ibm.com>

On Mon, 2025-03-10 at 14:04 +0100, Maximilian Immanuel Brandtner wrote:


[...]

> Just to make sure that everyone here is one the same page there is
> indeed a difference between the ordering of the control resize
> message
> and the kernel implementation; however as this bug has been around
> for
> ~15 years the spec should be changed instead, right?
> 
> I would like to get a clear ACK of the issue, as I would like to
> reference this discussion when creating a bug-report on the virtio-
> spec
> github.

I'm afraid you haven't understood the difference between a control
message for an individual port, and the config space for the entire
device.  Please re-read my post earlier in the thread, and follow the
code.  There's no divergence in the implementation and the spec, and
there's nothing to fix.  If anything, there may be a chance to add to
the spec the order for the control message - though I don't think
there's a strong need to.

		Amit

  reply	other threads:[~2025-03-18  9:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25  9:21 Maximilian Immanuel Brandtner
2025-03-03 11:54 ` Amit Shah
2025-03-05  9:53   ` Maximilian Immanuel Brandtner
2025-03-05 12:13     ` Niklas Schnelle
2025-03-05 12:15       ` Niklas Schnelle
2025-03-05 12:33         ` Maximilian Immanuel Brandtner
2025-03-10 13:04         ` Maximilian Immanuel Brandtner
2025-03-18  9:51           ` Amit Shah [this message]
2025-03-18 10:07   ` Maximilian Immanuel Brandtner
2025-03-18 14:25     ` Amit Shah
2025-03-19  8:54       ` Maximilian Immanuel Brandtner
2025-03-19  9:12         ` Amit Shah
2025-03-19 13:00       ` Maximilian Immanuel Brandtner
2025-03-19 15:00         ` Michael S. Tsirkin
2025-03-19 17:13           ` Halil Pasic
2025-03-19 21:21             ` Michael S. Tsirkin
2025-03-20  7:12             ` Maximilian Immanuel Brandtner
2025-03-20 10:41               ` Halil Pasic
2025-03-20 11:53                 ` Maximilian Immanuel Brandtner
2025-03-20 14:09                   ` Halil Pasic
2025-03-20 14:19                     ` Halil Pasic
2025-03-20 17:19                       ` Maximilian Immanuel Brandtner
2025-03-20  7:23       ` Maximilian Immanuel Brandtner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6760518ea9e65ec5d1a18861f88e0a758e0f3fa6.camel@kernel.org \
    --to=amit@kernel.org \
    --cc=arnd@arndb.de \
    --cc=brueckner@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxbr@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=schnelle@linux.ibm.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®