Re: [PATCH] misc: fastrpc: add missing MODULE_DEVICE_TABLE()

[Srinivas Kandagatla <srini@kernel.org>]

On 7/5/26 1:18 AM, Pengpeng Hou wrote:
> The driver has a match table for the of bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
> 
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.

Are you fixing a real issue?
Is this patch tested?
> 
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
> 

> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
>  drivers/misc/fastrpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 47356a5d5804..0d2196b3f632 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -2265,6 +2265,7 @@ static const struct of_device_id fastrpc_match_table[] = {
>  	{ .compatible = "qcom,fastrpc-compute-cb", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, fastrpc_match_table);

This is adding dead code, these devices are created dynamically by
fastrpc driver and does not have a standalone driver.

There is already a MODULE_DEVICE_TABLE for this driver.

--srini

>  
>  static struct platform_driver fastrpc_cb_driver = {
>  	.probe = fastrpc_cb_probe,