mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>, Judith Mendez <jm@ti.com>
Cc: <nm@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<stable@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
	<s-vadapalli@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Fix pinmux for pin M19 used by sdhci1
Date: Mon, 9 Mar 2026 10:28:01 +0530	[thread overview]
Message-ID: <677ef6a4-7825-45d1-a4ad-a5722e0d01c3@ti.com> (raw)
In-Reply-To: <baba390d-e695-4df2-adab-e76061a75601@ti.com>

On 09/03/26 10:05, Vignesh Raghavendra wrote:
> 
> 
> On 04/03/26 10:24, Siddharth Vadapalli wrote:
>> On 03/03/26 22:06, Judith Mendez wrote:
>>> Hi Siddharth,
>>>
>>> On 2/12/26 7:06 AM, Siddharth Vadapalli wrote:
>>>> According to the datasheet for the AM62Ax SoC [0], pin M19 has the
>>>> address
>>>> 0x000F40A8. Therefore, the offset to be passed to the AM62AX_IOPAD
>>>> macro is
>>>> 0xa8 and not 0x07c. With the existing incorrect offset, the following
>>>> error
>>>> is seen when Linux boots:
>>>>      fa00000.mmc: deferred probe pending: platform: supplier
>>>> regulator-5 not ready
>>>> with the SD Card being unusable and the boot process halting due to
>>>> the root
>>>> filesystem in the SD Card being inaccessible.
>>>>
>>>> Hence, fix it.
>>>>
>>>> [0]: https://www.ti.com/lit/ds/symlink/am62a7.pdf
>>>>
>>>> Fixes: 8f023012eb4a ("arm64: dts: ti: k3-am62a: Enable UHS mode
>>>> support for SD cards")
>>>> Cc: <stable@vger.kernel.org>
>>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>>> ---
>>>>
>>>> Hello,
>>>>
>>>> This patch is based on commit
>>>> 37a93dd5c49b Merge tag 'net-next-7.0' of git://git.kernel.org/pub/
>>>> scm/ linux/kernel/git/netdev/net-next
>>>> of Mainline Linux.
>>>>
>>>> Regards,
>>>> Siddharth.
>>>>
>>>>    arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/
>>>> boot/ dts/ti/k3-am62a7-sk.dts
>>>> index e99bdbc2e0cb..9cfe7e7b317b 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>>> @@ -398,7 +398,7 @@ AM62AX_IOPAD(0x01d4, PIN_INPUT, 7) /* (C15)
>>>> UART0_RTSn.GPIO1_23 */
>>>>        vddshv_sdio_pins_default: vddshv-sdio-default-pins {
>>>>            pinctrl-single,pins = <
>>>> -            AM62AX_IOPAD(0x07c, PIN_OUTPUT, 7) /* (M19)
>>>> GPMC0_CLK.GPIO0_31 */
>>>> +            AM62AX_IOPAD(0x0a8, PIN_OUTPUT, 7) /* (M19)
>>>> GPMC0_CLK.GPIO0_31 */
>>>
>>> What! I don't think this is right.
>>>
>>> Looking at device tree, regulator-5 is using main_gpio0 31 to control SD
>>> ENA with PMIC. Which is GPMC0_CLK (N22 pad) and VSEL_SD_SOC. Which is
>>> 0x000F407C address in the device datasheet. So as far as I can see, the
>>> original address is correct and just the (M19) name is wrong. Did you
>>> test this patch to see if that fixed the failure?
>> Yes, without this patch I saw the following:
>> [    2.108345] Waiting for root device PARTUUID=076c4a2a-02...
>> [   12.261669] platform fa00000.mmc: deferred probe pending: platform:
>> supplier regulator-5
>>
>> Since the pin was named 'M19' in the comment, I corrected the offset to
>> match that of M19 and the issue was fixed. So it seems that although it
>> fixed the issue, it isn't really a fix.
>>
> 
> Refer to the schematics and not datasheet for pin routing. Please submit
> patch fixing the comment to say N22
I have posted the v2 patch fixing the pin name at:
https://lore.kernel.org/r/20260309045539.2070793-1-s-vadapalli@ti.com/

      reply	other threads:[~2026-03-09  4:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 13:06 Siddharth Vadapalli
2026-03-03 16:36 ` Judith Mendez
2026-03-04  4:54   ` Siddharth Vadapalli
2026-03-09  4:35     ` Vignesh Raghavendra
2026-03-09  4:58       ` Siddharth Vadapalli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=677ef6a4-7825-45d1-a4ad-a5722e0d01c3@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jm@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=srk@ti.com \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®