* [PATCH] platform/chrome: cros-ec: make init_lock static
@ 2019-12-18 10:07 Ben Dooks (Codethink)
2019-12-20 9:04 ` Enric Balletbo i Serra
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-18 10:07 UTC (permalink / raw)
To: ben.dooks
Cc: Benson Leung, Enric Balletbo i Serra, Guenter Roeck, linux-kernel
The init_lock is not declared or used outside of cros_ec_ishtp.c
so make it static to avoid the following warning:
drivers/platform/chrome/cros_ec_ishtp.c:79:1: warning: symbol 'init_lock' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Benson Leung <bleung@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: linux-kernel@vger.kernel.org
---
drivers/platform/chrome/cros_ec_ishtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
index e5996821d08b..5f8e76f3022a 100644
--- a/drivers/platform/chrome/cros_ec_ishtp.c
+++ b/drivers/platform/chrome/cros_ec_ishtp.c
@@ -76,7 +76,7 @@ struct cros_ish_in_msg {
*
* The writers are .reset() and .probe() function.
*/
-DECLARE_RWSEM(init_lock);
+static DECLARE_RWSEM(init_lock);
/**
* struct response_info - Encapsulate firmware response related
--
2.24.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] platform/chrome: cros-ec: make init_lock static
2019-12-18 10:07 [PATCH] platform/chrome: cros-ec: make init_lock static Ben Dooks (Codethink)
@ 2019-12-20 9:04 ` Enric Balletbo i Serra
0 siblings, 0 replies; 2+ messages in thread
From: Enric Balletbo i Serra @ 2019-12-20 9:04 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: Benson Leung, Guenter Roeck, linux-kernel
Hi Ben,
Thanks for the patch.
On 18/12/19 11:07, Ben Dooks (Codethink) wrote:
> The init_lock is not declared or used outside of cros_ec_ishtp.c
> so make it static to avoid the following warning:
>
> drivers/platform/chrome/cros_ec_ishtp.c:79:1: warning: symbol 'init_lock' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Applied for 5.6
> ---
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/platform/chrome/cros_ec_ishtp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
> index e5996821d08b..5f8e76f3022a 100644
> --- a/drivers/platform/chrome/cros_ec_ishtp.c
> +++ b/drivers/platform/chrome/cros_ec_ishtp.c
> @@ -76,7 +76,7 @@ struct cros_ish_in_msg {
> *
> * The writers are .reset() and .probe() function.
> */
> -DECLARE_RWSEM(init_lock);
> +static DECLARE_RWSEM(init_lock);
>
> /**
> * struct response_info - Encapsulate firmware response related
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-20 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 10:07 [PATCH] platform/chrome: cros-ec: make init_lock static Ben Dooks (Codethink)
2019-12-20 9:04 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®