* [PATCH 0/2] drm/msm/a6xx: use correct timestamp counter on A750 GPU
@ 2026-09-08 13:24 Neil Armstrong
2026-09-08 13:24 ` [PATCH 1/2] drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs Neil Armstrong
2026-09-08 13:24 ` [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on " Neil Armstrong
0 siblings, 2 replies; 11+ messages in thread
From: Neil Armstrong @ 2026-09-08 13:24 UTC (permalink / raw)
To: Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten,
David Airlie, Simona Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Neil Armstrong
The A750 uses a different counter register as used on the downstream
driver:
static u64 gen7_9_0_read_alwayson(struct adreno_device *adreno_dev)
{
...
/* Always use the GMU AO counter when doing a AHB read */
gmu_core_regread(device, GEN7_GMU_CX_AO_COUNTER_HI, &hi);
gmu_core_regread(device, GEN7_GMU_CX_AO_COUNTER_LO, &lo);
...
}
gen7_reg.h:#define GEN7_GMU_CX_AO_COUNTER_LO 0x1f880
gen7_reg.h:#define GEN7_GMU_CX_AO_COUNTER_HI 0x1f881
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (2):
drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs
drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++---
drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml | 2 ++
2 files changed, 11 insertions(+), 3 deletions(-)
---
base-commit: df2908090cda368b01ff43709f51890076c56157
change-id: 20260908-topic-sm8650-gmu-a750-timestamp-reg-2e7575e6279d
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/2] drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs 2026-09-08 13:24 [PATCH 0/2] drm/msm/a6xx: use correct timestamp counter on A750 GPU Neil Armstrong @ 2026-09-08 13:24 ` Neil Armstrong 2026-09-08 13:39 ` Neil Armstrong 2026-09-08 13:24 ` [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on " Neil Armstrong 1 sibling, 1 reply; 11+ messages in thread From: Neil Armstrong @ 2026-09-08 13:24 UTC (permalink / raw) To: Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Neil Armstrong The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER register on A6xx and other A7xx GPUs. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml b/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml index 33404eb18fd0..3fe7bc3ea93d 100644 --- a/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml +++ b/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml @@ -141,6 +141,8 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd"> <reg32 offset="0x1f9f0" name="GMU_BOOT_KMD_LM_HANDSHAKE"/> <reg32 offset="0x1f957" name="GMU_LLM_GLM_SLEEP_CTRL"/> <reg32 offset="0x1f958" name="GMU_LLM_GLM_SLEEP_STATUS"/> + <reg32 offset="0x1f880" name="GMU_CX_AO_COUNTER_H" variants="A7XX"/> + <reg32 offset="0x1f881" name="GMU_CX_AO_COUNTER_L" variants="A7XX"/> <reg32 offset="0x1f888" name="GMU_ALWAYS_ON_COUNTER_L" variants="A6XX-A7XX"/> <reg32 offset="0x1f840" name="GMU_ALWAYS_ON_COUNTER_L" variants="A8XX-"/> <reg32 offset="0x1f889" name="GMU_ALWAYS_ON_COUNTER_H" variants="A6XX-A7XX"/> -- 2.34.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs 2026-09-08 13:24 ` [PATCH 1/2] drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs Neil Armstrong @ 2026-09-08 13:39 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2026-09-08 13:39 UTC (permalink / raw) To: Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel On 9/8/26 15:24, Neil Armstrong wrote: > The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER > register on A6xx and other A7xx GPUs. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml b/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml > index 33404eb18fd0..3fe7bc3ea93d 100644 > --- a/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml > +++ b/drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml > @@ -141,6 +141,8 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd"> > <reg32 offset="0x1f9f0" name="GMU_BOOT_KMD_LM_HANDSHAKE"/> > <reg32 offset="0x1f957" name="GMU_LLM_GLM_SLEEP_CTRL"/> > <reg32 offset="0x1f958" name="GMU_LLM_GLM_SLEEP_STATUS"/> > + <reg32 offset="0x1f880" name="GMU_CX_AO_COUNTER_H" variants="A7XX"/> > + <reg32 offset="0x1f881" name="GMU_CX_AO_COUNTER_L" variants="A7XX"/> It's swapped.... please ignore this patchset I'll send a v2 with the proper offsets > <reg32 offset="0x1f888" name="GMU_ALWAYS_ON_COUNTER_L" variants="A6XX-A7XX"/> > <reg32 offset="0x1f840" name="GMU_ALWAYS_ON_COUNTER_L" variants="A8XX-"/> > <reg32 offset="0x1f889" name="GMU_ALWAYS_ON_COUNTER_H" variants="A6XX-A7XX"/> > Neil ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-08 13:24 [PATCH 0/2] drm/msm/a6xx: use correct timestamp counter on A750 GPU Neil Armstrong 2026-09-08 13:24 ` [PATCH 1/2] drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs Neil Armstrong @ 2026-09-08 13:24 ` Neil Armstrong 2026-09-09 9:06 ` Konrad Dybcio 2026-09-09 18:31 ` Akhil P Oommen 1 sibling, 2 replies; 11+ messages in thread From: Neil Armstrong @ 2026-09-08 13:24 UTC (permalink / raw) To: Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Neil Armstrong The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER register on A6xx and other A7xx GPUs, use it when running a A750 GPU. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index f9de9329dee3..081e79ea4652 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) u64 count_hi, count_lo, temp; do { - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); + if (adreno_is_a750_family(adreno_gpu)) { + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); + } else { + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); + temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); + } } while (unlikely(count_hi != temp)); return (count_hi << 32) | count_lo; -- 2.34.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-08 13:24 ` [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on " Neil Armstrong @ 2026-09-09 9:06 ` Konrad Dybcio 2026-09-09 9:32 ` Neil Armstrong 2026-09-09 18:31 ` Akhil P Oommen 1 sibling, 1 reply; 11+ messages in thread From: Konrad Dybcio @ 2026-09-09 9:06 UTC (permalink / raw) To: Neil Armstrong, Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel On 9/8/26 3:24 PM, Neil Armstrong wrote: > The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER > register on A6xx and other A7xx GPUs, use it when running a A750 GPU. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index f9de9329dee3..081e79ea4652 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) > u64 count_hi, count_lo, temp; > > do { > - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); > - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > + if (adreno_is_a750_family(adreno_gpu)) { > + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); > + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); KGSL apparently *writes* the system time to these registers, is that an idiosyncrasy regarding how the vendor userland drivers then use this counter? Konrad P.S. looks like a8xx also has this counter ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-09 9:06 ` Konrad Dybcio @ 2026-09-09 9:32 ` Neil Armstrong 2026-09-09 13:24 ` Connor Abbott 0 siblings, 1 reply; 11+ messages in thread From: Neil Armstrong @ 2026-09-09 9:32 UTC (permalink / raw) To: Konrad Dybcio, Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel On 9/9/26 11:06, Konrad Dybcio wrote: > On 9/8/26 3:24 PM, Neil Armstrong wrote: >> The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER >> register on A6xx and other A7xx GPUs, use it when running a A750 GPU. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> index f9de9329dee3..081e79ea4652 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) >> u64 count_hi, count_lo, temp; >> >> do { >> - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >> - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); >> - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >> + if (adreno_is_a750_family(adreno_gpu)) { >> + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); >> + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); >> + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > > KGSL apparently *writes* the system time to these registers, is that > an idiosyncrasy regarding how the vendor userland drivers then use > this counter? This is a GMU counter, no sure why & how KGSL or freedreno would write anything to it... > > Konrad > > P.S. looks like a8xx also has this counter > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-09 9:32 ` Neil Armstrong @ 2026-09-09 13:24 ` Connor Abbott 2026-09-09 14:29 ` Neil Armstrong 0 siblings, 1 reply; 11+ messages in thread From: Connor Abbott @ 2026-09-09 13:24 UTC (permalink / raw) To: Neil Armstrong Cc: Konrad Dybcio, Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter, linux-arm-msm, dri-devel, freedreno, linux-kernel On Wed, Sep 9, 2026 at 5:32 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 9/9/26 11:06, Konrad Dybcio wrote: > > On 9/8/26 3:24 PM, Neil Armstrong wrote: > >> The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER > >> register on A6xx and other A7xx GPUs, use it when running a A750 GPU. > >> > >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > >> --- > >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- > >> 1 file changed, 9 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >> index f9de9329dee3..081e79ea4652 100644 > >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >> @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) > >> u64 count_hi, count_lo, temp; > >> > >> do { > >> - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > >> - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); > >> - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > >> + if (adreno_is_a750_family(adreno_gpu)) { > >> + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > >> + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); > >> + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > > > > KGSL apparently *writes* the system time to these registers, is that > > an idiosyncrasy regarding how the vendor userland drivers then use > > this counter? > > This is a GMU counter, no sure why & how KGSL or freedreno would write anything to it... It is writeable. This is part of implementing VK_KHR_calibrated_timestamps. The idea is that when the GPU suspends and resumes, we keep track of how many ticks it would've taken and then pretend to advance the counter by writing the CX counter (after powering on CX but before powering on GX which initializes the normal GMU counter). Note that VK_KHR_calibrated_timestamps worked initially on turnip but the tests started failing with v6.19. I haven't bisected yet but my guess is CX was never actually collapsing for whatever reason and we made it collapse hence breaking the tests. So we probably do need this. Connor > > > > > Konrad > > > > P.S. looks like a8xx also has this counter > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-09 13:24 ` Connor Abbott @ 2026-09-09 14:29 ` Neil Armstrong 2026-09-09 14:31 ` Connor Abbott 0 siblings, 1 reply; 11+ messages in thread From: Neil Armstrong @ 2026-09-09 14:29 UTC (permalink / raw) To: Connor Abbott Cc: Konrad Dybcio, Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter, linux-arm-msm, dri-devel, freedreno, linux-kernel On 9/9/26 15:24, Connor Abbott wrote: > On Wed, Sep 9, 2026 at 5:32 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> On 9/9/26 11:06, Konrad Dybcio wrote: >>> On 9/8/26 3:24 PM, Neil Armstrong wrote: >>>> The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER >>>> register on A6xx and other A7xx GPUs, use it when running a A750 GPU. >>>> >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>> --- >>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- >>>> 1 file changed, 9 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>> index f9de9329dee3..081e79ea4652 100644 >>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>> @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) >>>> u64 count_hi, count_lo, temp; >>>> >>>> do { >>>> - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >>>> - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); >>>> - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >>>> + if (adreno_is_a750_family(adreno_gpu)) { >>>> + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); >>>> + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); >>>> + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); >>> >>> KGSL apparently *writes* the system time to these registers, is that >>> an idiosyncrasy regarding how the vendor userland drivers then use >>> this counter? >> >> This is a GMU counter, no sure why & how KGSL or freedreno would write anything to it... > > It is writeable. This is part of implementing > VK_KHR_calibrated_timestamps. The idea is that when the GPU suspends > and resumes, we keep track of how many ticks it would've taken and > then pretend to advance the counter by writing the CX counter (after > powering on CX but before powering on GX which initializes the normal > GMU counter). > > Note that VK_KHR_calibrated_timestamps worked initially on turnip but > the tests started failing with v6.19. I haven't bisected yet but my > guess is CX was never actually collapsing for whatever reason and we > made it collapse hence breaking the tests. So we probably do need > this. OK thanks for the detail! Today it's only used for perfetto, but still on A750 a different register is used for this purpose. Neil > > Connor > >> >>> >>> Konrad >>> >>> P.S. looks like a8xx also has this counter >>> >> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-09 14:29 ` Neil Armstrong @ 2026-09-09 14:31 ` Connor Abbott 0 siblings, 0 replies; 11+ messages in thread From: Connor Abbott @ 2026-09-09 14:31 UTC (permalink / raw) To: Neil Armstrong Cc: Konrad Dybcio, Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter, linux-arm-msm, dri-devel, freedreno, linux-kernel On Wed, Sep 9, 2026 at 10:29 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 9/9/26 15:24, Connor Abbott wrote: > > On Wed, Sep 9, 2026 at 5:32 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > >> > >> On 9/9/26 11:06, Konrad Dybcio wrote: > >>> On 9/8/26 3:24 PM, Neil Armstrong wrote: > >>>> The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER > >>>> register on A6xx and other A7xx GPUs, use it when running a A750 GPU. > >>>> > >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > >>>> --- > >>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- > >>>> 1 file changed, 9 insertions(+), 3 deletions(-) > >>>> > >>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >>>> index f9de9329dee3..081e79ea4652 100644 > >>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >>>> @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) > >>>> u64 count_hi, count_lo, temp; > >>>> > >>>> do { > >>>> - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > >>>> - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); > >>>> - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > >>>> + if (adreno_is_a750_family(adreno_gpu)) { > >>>> + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > >>>> + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); > >>>> + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > >>> > >>> KGSL apparently *writes* the system time to these registers, is that > >>> an idiosyncrasy regarding how the vendor userland drivers then use > >>> this counter? > >> > >> This is a GMU counter, no sure why & how KGSL or freedreno would write anything to it... > > > > It is writeable. This is part of implementing > > VK_KHR_calibrated_timestamps. The idea is that when the GPU suspends > > and resumes, we keep track of how many ticks it would've taken and > > then pretend to advance the counter by writing the CX counter (after > > powering on CX but before powering on GX which initializes the normal > > GMU counter). > > > > Note that VK_KHR_calibrated_timestamps worked initially on turnip but > > the tests started failing with v6.19. I haven't bisected yet but my > > guess is CX was never actually collapsing for whatever reason and we > > made it collapse hence breaking the tests. So we probably do need > > this. > > OK thanks for the detail! Today it's only used for perfetto, but still > on A750 a different register is used for this purpose. > > Neil Well technically no, today this function is also used by VK_KHR_calibrated_timestamps on turnip and today it's broken because of a kernel regression... Connor > > > > > Connor > > > >> > >>> > >>> Konrad > >>> > >>> P.S. looks like a8xx also has this counter > >>> > >> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-08 13:24 ` [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on " Neil Armstrong 2026-09-09 9:06 ` Konrad Dybcio @ 2026-09-09 18:31 ` Akhil P Oommen 2026-09-10 6:57 ` Neil Armstrong 1 sibling, 1 reply; 11+ messages in thread From: Akhil P Oommen @ 2026-09-09 18:31 UTC (permalink / raw) To: Neil Armstrong Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Rob Clark, Sean Paul, Konrad Dybcio, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter On 9/8/2026 6:54 PM, Neil Armstrong wrote: > The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER > register on A6xx and other A7xx GPUs, use it when running a A750 GPU. Do you see any difference in behavior? Both counters are synchronized. -Akhil. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index f9de9329dee3..081e79ea4652 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) > u64 count_hi, count_lo, temp; > > do { > - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); > - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > + if (adreno_is_a750_family(adreno_gpu)) { > + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); > + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); > + } else { > + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); > + temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); > + } > } while (unlikely(count_hi != temp)); > > return (count_hi << 32) | count_lo; > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on a750 GPUs 2026-09-09 18:31 ` Akhil P Oommen @ 2026-09-10 6:57 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2026-09-10 6:57 UTC (permalink / raw) To: Akhil P Oommen Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Rob Clark, Sean Paul, Konrad Dybcio, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter On 9/9/26 20:31, Akhil P Oommen wrote: > > > On 9/8/2026 6:54 PM, Neil Armstrong wrote: >> The a750 uses the CX AO Counters instead of the GMU_ALWAYS_ON_COUNTER >> register on A6xx and other A7xx GPUs, use it when running a A750 GPU. > > Do you see any difference in behavior? Both counters are synchronized. GMU_ALWAYS_ON_COUNTER_H/L returns 0 on SM8650 Neil > > -Akhil. > >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> index f9de9329dee3..081e79ea4652 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> @@ -23,9 +23,15 @@ static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) >> u64 count_hi, count_lo, temp; >> >> do { >> - count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >> - count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); >> - temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >> + if (adreno_is_a750_family(adreno_gpu)) { >> + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); >> + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_L); >> + temp = gmu_read(&a6xx_gpu->gmu, REG_A7XX_GMU_CX_AO_COUNTER_H); >> + } else { >> + count_hi = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >> + count_lo = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_L); >> + temp = gmu_read(&a6xx_gpu->gmu, REG_A6XX_GMU_ALWAYS_ON_COUNTER_H); >> + } >> } while (unlikely(count_hi != temp)); >> >> return (count_hi << 32) | count_lo; >> > ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-09-10 6:57 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-09-08 13:24 [PATCH 0/2] drm/msm/a6xx: use correct timestamp counter on A750 GPU Neil Armstrong 2026-09-08 13:24 ` [PATCH 1/2] drm/msm/a6xx: Add CX AO Counter registers used for a750 GPUs Neil Armstrong 2026-09-08 13:39 ` Neil Armstrong 2026-09-08 13:24 ` [PATCH 2/2] drm/msm/a6xx: Use CX AO Counter register for timestamp on " Neil Armstrong 2026-09-09 9:06 ` Konrad Dybcio 2026-09-09 9:32 ` Neil Armstrong 2026-09-09 13:24 ` Connor Abbott 2026-09-09 14:29 ` Neil Armstrong 2026-09-09 14:31 ` Connor Abbott 2026-09-09 18:31 ` Akhil P Oommen 2026-09-10 6:57 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®