* [PATCH 0/1] update display OVL config check
@ 2025-11-18 2:22 Xiandong Wang
2025-11-18 2:22 ` [PATCH 1/1] drm/mediatek: Add check framebuffer width and height size before config ovl Xiandong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Xiandong Wang @ 2025-11-18 2:22 UTC (permalink / raw)
To: Jassi Brar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Yongqiang Niu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
sirius.wang, vince-wl.liu, jh.hsu,
Project_Global_Chrome_Upstream_Group, Xiandong Wang
add framebuffer width and height size check
Xiandong Wang (1):
drm/mediatek: Add check framebuffer width and height size before
config ovl
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.46.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] drm/mediatek: Add check framebuffer width and height size before config ovl
2025-11-18 2:22 [PATCH 0/1] update display OVL config check Xiandong Wang
@ 2025-11-18 2:22 ` Xiandong Wang
2025-11-18 8:44 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 3+ messages in thread
From: Xiandong Wang @ 2025-11-18 2:22 UTC (permalink / raw)
To: Jassi Brar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Yongqiang Niu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
sirius.wang, vince-wl.liu, jh.hsu,
Project_Global_Chrome_Upstream_Group, Xiandong Wang
During the execution of the IGT test kms_cursor_edge_walk,
the screen experiences glitches and the hardware hangs.
It was discovered that the framebuffer dimensions (width and height)
provided by IGT to the display driver are zero, leading to
abnormal parameters that cause the hardware to freeze.
Therefore, it is necessary to verify the buffer dimensions
before successfully passing the IGT test.
Signed-off-by: Xiandong Wang <xiandong.wang@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index f1fa1f1c3ff0..bb207aee91f2 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -611,7 +611,7 @@ void mtk_ovl_layer_config(struct device *dev, unsigned int idx,
unsigned int ignore_pixel_alpha = 0;
unsigned int con;
- if (!pending->enable) {
+ if (!pending->enable || !pending->height || !pending->width) {
mtk_ovl_layer_off(dev, idx, cmdq_pkt);
return;
}
--
2.46.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/mediatek: Add check framebuffer width and height size before config ovl
2025-11-18 2:22 ` [PATCH 1/1] drm/mediatek: Add check framebuffer width and height size before config ovl Xiandong Wang
@ 2025-11-18 8:44 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-11-18 8:44 UTC (permalink / raw)
To: Xiandong Wang, Jassi Brar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, Yongqiang Niu
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
sirius.wang, vince-wl.liu, jh.hsu,
Project_Global_Chrome_Upstream_Group
Il 18/11/25 03:22, Xiandong Wang ha scritto:
> During the execution of the IGT test kms_cursor_edge_walk,
> the screen experiences glitches and the hardware hangs.
> It was discovered that the framebuffer dimensions (width and height)
> provided by IGT to the display driver are zero, leading to
> abnormal parameters that cause the hardware to freeze.
> Therefore, it is necessary to verify the buffer dimensions
> before successfully passing the IGT test.
>
> Signed-off-by: Xiandong Wang <xiandong.wang@mediatek.com>
Needs a Fixes tag.
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers,
Angelo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-18 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-18 2:22 [PATCH 0/1] update display OVL config check Xiandong Wang
2025-11-18 2:22 ` [PATCH 1/1] drm/mediatek: Add check framebuffer width and height size before config ovl Xiandong Wang
2025-11-18 8:44 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®