From: Shuah Khan <shuah@kernel.org>
To: Yuyang Du <yuyang.du@intel.com>, valentina.manea.m@gmail.com
Cc: gregkh@linuxfoundation.org, k.opasiak@samsung.com,
kstewart@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, juan.zea@qindel.com,
Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather
Date: Thu, 30 Nov 2017 08:00:06 -0700 [thread overview]
Message-ID: <67d4e73f-28a3-27c6-064b-6a471a89661c@kernel.org> (raw)
In-Reply-To: <1512008560-28594-1-git-send-email-yuyang.du@intel.com>
On 11/29/2017 07:22 PM, Yuyang Du wrote:
> The previous USB3 SuperSpeed enabling patches mistakenly enabled
> URB scatter-gather chaining, which is actually not supported by
> the VHCI HCD. This patch fixes that.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867
> Fixes: 03cd00d538a6feb ("usbip: vhci-hcd: Set the vhci structure up to work")
> Reported-by: Juan Zea <juan.zea@qindel.com>
> Signed-off-by: Yuyang Du <yuyang.du@intel.com>> ---
> drivers/usb/usbip/vhci_hcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 713e941..6b3278c 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1098,7 +1098,6 @@ static int hcd_name_to_id(const char *name)
> static int vhci_setup(struct usb_hcd *hcd)
> {
> struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller));
> - hcd->self.sg_tablesize = ~0;
> if (usb_hcd_is_primary_hcd(hcd)) {
> vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd);
> vhci->vhci_hcd_hs->vhci = vhci;
>
This need to go into stable as well. It applies to 4.14
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
thanks,
-- Shuah
prev parent reply other threads:[~2017-11-30 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 2:22 Yuyang Du
2017-11-30 15:00 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d4e73f-28a3-27c6-064b-6a471a89661c@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=juan.zea@qindel.com \
--cc=k.opasiak@samsung.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=valentina.manea.m@gmail.com \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®