mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kselftest@vger.kernel.org
Cc: Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] x86/selftests/xsave: Introduce XSAVE tests
Date: Wed, 27 Feb 2019 13:45:15 -0800	[thread overview]
Message-ID: <67fa7d2a-31e2-efdf-7ffe-39c3e2a9b4a2@intel.com> (raw)
In-Reply-To: <20190227212422.11845-1-yu-cheng.yu@intel.com>

On 2/27/19 1:24 PM, Yu-cheng Yu wrote:
> In the past there were some issues resulting from additions to
> XSAVE/XSAVES.  Introduce a few tests to help detect issues early.

Thanks for doing this!

I wonder, though, if you can spend a little more time on these.  They
look a little "raw".  They're virtually free of comments and there is no
explanation of what the tests do or why they do them.  I honestly forget
things like what XSAVE has to do with fork() failing, for instance.

I'd question why we need 5 different .c files.  It also seems like
things like set_ymm() could be trivially factored into a .h rather than
making 5 copies of them.

selftests don't need to be perfect, but I think these could use a _bit_
more polish before merging.

  reply	other threads:[~2019-02-27 21:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 21:24 Yu-cheng Yu
2019-02-27 21:45 ` Dave Hansen [this message]
2019-02-27 22:19   ` Yu-cheng Yu
2019-02-27 22:30     ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67fa7d2a-31e2-efdf-7ffe-39c3e2a9b4a2@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®