From: Yu-cheng Yu <yu-cheng.yu@intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kselftest@vger.kernel.org
Cc: Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] x86/selftests/xsave: Introduce XSAVE tests
Date: Wed, 27 Feb 2019 14:19:27 -0800 [thread overview]
Message-ID: <6be796c64cb4ba21ef879facc65f5b3b476cacfd.camel@intel.com> (raw)
In-Reply-To: <67fa7d2a-31e2-efdf-7ffe-39c3e2a9b4a2@intel.com>
On Wed, 2019-02-27 at 13:45 -0800, Dave Hansen wrote:
> I wonder, though, if you can spend a little more time on these. They
> look a little "raw". They're virtually free of comments and there is no
> explanation of what the tests do or why they do them. I honestly forget
> things like what XSAVE has to do with fork() failing, for instance.
I will add comments of what problems each test detects.
> I'd question why we need 5 different .c files. It also seems like
> things like set_ymm() could be trivially factored into a .h rather than
> making 5 copies of them.
Each C file contains only one single test and can be built with one command,
e.g. "gcc xsave_check_exec.c", or as part of the whole selftest.
I am hoping that, should any test fail, one can easily modify the test to find
out why.
Yes, I will move set_ymm() to a header file.
Yu-cheng
next prev parent reply other threads:[~2019-02-27 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 21:24 Yu-cheng Yu
2019-02-27 21:45 ` Dave Hansen
2019-02-27 22:19 ` Yu-cheng Yu [this message]
2019-02-27 22:30 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be796c64cb4ba21ef879facc65f5b3b476cacfd.camel@intel.com \
--to=yu-cheng.yu@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®