mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriel FERNANDEZ <gabriel.fernandez@foss.st.com>
To: Conor Dooley <conor@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: arm: stm32: Add clock-controller sub-node to STM32MP2 SYSCFG
Date: Wed, 18 Nov 2026 13:23:31 +0100	[thread overview]
Message-ID: <67ff81c6-fba3-4357-b297-079c2ea2ebc0@foss.st.com> (raw)
In-Reply-To: <20261112-worsening-yahoo-323ef21dc921@spud>

Hi Conor,

On 11/12/26 19:38, Conor Dooley wrote:
> On Thu, Nov 12, 2026 at 09:36:59AM +0100, Gabriel FERNANDEZ wrote:
>> Hi Conor,
>>
>> Thanks for review
>>
>> On 11/10/26 19:54, Conor Dooley wrote:
>>> On Tue, Nov 10, 2026 at 11:42:17AM +0100, Gabriel Fernandez wrote:
>>>> The LTDC pixel clock multiplexer of the STM32MP23x and STM32MP25x
>>>> SYSCFG is described by a clock-controller sub-node of the SYSCFG node.
>>>>
>>>> Add this sub-node to the SYSCFG binding. It is required on STM32MP23x
>>>> and STM32MP25x and not allowed on the other SoCs.
>>>>
>>>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>> Why does this need a child node at all, can't the clock controller
>>> properties go straight into this syscon node?
>>>
>>> Cheers,
>>> Conor.
>> I sent a v2 [1] shortly before your reply, which explains this in the
>> commit message, but the question still applies to it, so let me answer
>> here.
>>
>>  From a hardware point of view, the mux inputs could indeed be described
>> in the SYSCFG node. The problem is that this node is a "syscon": when
>> the syscon core creates the regmap of the node (syscon_node_to_regmap()
>> or syscon_regmap_lookup_by_*()), it takes the first clock of the node as
>> the clock of the registers, keeps it prepared and enables/disables it
>> around each register access.
>>
>> The SYSCFG has no clock gate in the RCC, so this first clock would be
>> the LTDC kernel clock, i.e. the first input of the mux. It would then be
>> enabled on every SYSCFG access by all the users of this syscon (PCIe,
>> ComboPHY, Ethernet, OMM...).
> Why are any of these things getting probed before the clock controller?
> I had it in my head that clock initialisation was done super early on,
> before smp even begins, so the clock driver would probe and generate the
> regmap before this can happen?
Only the clock providers declared with CLK_OF_DECLARE() are initialised
that early. Here the SYSCFG node isn't bound to a clock driver but to
the STM32MP2 SYSCFG driver (drivers/soc/st), a platform driver which
populates the USB2 PHY sub-nodes. The mux parents come from the RCC,
which is also a platform driver, with SCMI parents.

That said, your suggestion was the right direction, and Krzysztof asked
for the same on v2. v3 [1] drops the child node and puts the clock
properties in the SYSCFG node. The SYSCFG driver now creates the regmap
itself and registers it with of_syscon_register_regmap() before

populating its sub-nodes and creating the clock device, so the syscon

core doesn't attach the LTDC kernel clock to it.


Best regards,
Gabriel

>
>> Registering our own regmap with of_syscon_register_regmap() from the
>> SYSCFG driver doesn't solve it either: these users reach the SYSCFG
>> through vendor phandles (st,syscon, st,syscfg-amcr) or by compatible,
>> which are not tracked by fw_devlink, so one of them can create the
>> syscon regmap, with the clock, before the SYSCFG driver probes.
>>
>> Apart from adding a dummy clock in first position, which would describe
>> something which doesn't exist in the hardware, I didn't find a way to
>> keep these properties in the SYSCFG node. So the mux is described by a
>> sub-node with its own clock inputs, like the USB2 PHYs of the SYSCFG
>> which are already described as sub-nodes.
>>
>> In v2, the '#clock-cells' property of the SYSCFG node is deprecated, so
>> that the sub-node is the only provider of this clock. No driver ever
>> registered a clock on the SYSCFG node, so this doesn't change anything
>> for existing devicetrees.
>>
>> [1] https://lore.kernel.org/r/20261110-ups_mp25_clk_syscfg-v2-0-624559bb8ec7@foss.st.com
>>
>> Best regards,
>>
>> Gabriel
>>
>>
>>>> ---
>>>>    Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 6 ++++++
>>>>    1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>>>> index a559f8b03b84..38c844e8f19d 100644
>>>> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>>>> @@ -45,6 +45,10 @@ properties:
>>>>      "#size-cells":
>>>>        const: 1
>>>> +  clock-controller:
>>>> +    type: object
>>>> +    $ref: /schemas/clock/st,stm32mp25-syscfg-clk.yaml#
>>>> +
>>>>    patternProperties:
>>>>      "^phy@2[48]00$":
>>>>        type: object
>>>> @@ -80,6 +84,7 @@ allOf:
>>>>            - "#address-cells"
>>>>            - "#clock-cells"
>>>>            - "#size-cells"
>>>> +        - clock-controller
>>>>            - phy@2400
>>>>            - phy@2800
>>>>        else:
>>>> @@ -87,6 +92,7 @@ allOf:
>>>>            '#address-cells': false
>>>>            '#clock-cells': false
>>>>            '#size-cells': false
>>>> +        clock-controller: false
>>>>            phy@2400: false
>>>>            phy@2800: false
>>>>
>>>> -- 
>>>> 2.43.0
>>>>

  reply	other threads:[~2026-11-18 12:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 10:42 [PATCH 0/5] clk: stm32: Add the STM32MP2 SYSCFG LTDC pixel clock mux Gabriel Fernandez
2026-11-10 10:42 ` [PATCH 1/5] dt-bindings: clock: Add STM32MP25 SYSCFG clock controller Gabriel Fernandez
2026-11-10 10:42 ` [PATCH 2/5] dt-bindings: arm: stm32: Add clock-controller sub-node to STM32MP2 SYSCFG Gabriel Fernandez
2026-11-10 18:54   ` Conor Dooley
2026-11-12  8:36     ` Gabriel FERNANDEZ
2026-11-12 18:38       ` Conor Dooley
2026-11-18 12:23         ` Gabriel FERNANDEZ [this message]
2026-11-10 10:42 ` [PATCH 3/5] clk: stm32: Add STM32MP25 SYSCFG clock driver Gabriel Fernandez
2026-11-13  6:25   ` Uwe Kleine-König
2026-11-10 10:42 ` [PATCH 4/5] arm64: dts: st: add LTDC pixel clock controller on stm32mp23 Gabriel Fernandez
2026-11-10 10:42 ` [PATCH 5/5] arm64: dts: st: add LTDC pixel clock controller on stm32mp25 Gabriel Fernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67ff81c6-fba3-4357-b297-079c2ea2ebc0@foss.st.com \
    --to=gabriel.fernandez@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bmasney+clk@redhat.com \
    --cc=christophe.roullier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®