mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luca <kronos.it@gmail.com>
To: "Bjorn Helgaas" <bjorn.helgaas@hp.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Enable legacy support for serial ports when SERIAL_8250_PNP is disabled
Date: Wed, 11 Jul 2007 21:40:07 +0200	[thread overview]
Message-ID: <68676e00707111240v28263cc7i13c033c8be1339b9@mail.gmail.com> (raw)
In-Reply-To: <200707091230.01556.bjorn.helgaas@hp.com>

On 7/9/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Monday 09 July 2007 11:30:59 am Luca wrote:
> > On 7/9/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > > If you turn off
> > > PNP completely, you will have "pnp_platform_devices == 0", and the
> > > existing code will do what you need.
> >
> > Well for me it's a non-issue, I'm able to "work-around" it in many
> > ways. My point is that a configuration that used to work and is still
> > valid suddenly doesn't work anymore.
>
> You're right about that, and it is a legitimate issue.  But given the
> fact that (PNP && !SERIAL_8250_PNP) should be relatively unusual, my
> opinion is that it's not worth extra ifdefs in legacy_serial.c.
>
> If you have to use any workarounds like "legacy_serial.force", I think
> that's a bug, and I'll fix it.

Ok, I double-checked: the serial port is usable during boot with PNP
enabled, so no problem with dropping my patch.

Luca

  reply	other threads:[~2007-07-11 19:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-07 23:33 Luca Tettamanti
2007-07-09 15:46 ` Bjorn Helgaas
2007-07-09 17:30   ` Luca
2007-07-09 18:30     ` Bjorn Helgaas
2007-07-11 19:40       ` Luca [this message]
2007-07-11 21:07         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68676e00707111240v28263cc7i13c033c8be1339b9@mail.gmail.com \
    --to=kronos.it@gmail.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®