mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luca Tettamanti <kronos.it@gmail.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Enable legacy support for serial ports when SERIAL_8250_PNP is disabled
Date: Sun, 8 Jul 2007 01:33:00 +0200	[thread overview]
Message-ID: <20070707233300.GA3267@dreamland.darkstar.lan> (raw)

Hi Bjorn,
your patch:

commit 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26
Author: Bjorn Helgaas <bjorn.helgaas@hp.com>
Date:   Tue May 8 00:36:07 2007 -0700

    x86, serial: convert legacy COM ports to platform devices

disables probing using legacy code in favour of ACPI/PNP to avoid double
discovery.

However if SERIAL_8250_PNP is not enabled the user is left without
serial ports (been there, done that - my kernel config suddenly wasn't
working anymore). So:

Enable probing of serial ports using legacy code when PNP code
(SERIAL_8250_PNP) is not enabled.

Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>

---

 arch/i386/kernel/legacy_serial.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/i386/kernel/legacy_serial.c b/arch/i386/kernel/legacy_serial.c
index 2151011..457d307 100644
--- a/arch/i386/kernel/legacy_serial.c
+++ b/arch/i386/kernel/legacy_serial.c
@@ -48,7 +48,11 @@ static struct platform_device x86_com_device = {
 	},
 };
 
+#ifndef CONFIG_SERIAL_8250_PNP
+static int force_legacy_probe = 1;
+#else
 static int force_legacy_probe;
+#endif
 module_param_named(force, force_legacy_probe, bool, 0);
 MODULE_PARM_DESC(force, "Force legacy serial port probe");
 


Luca
-- 
La vispa candela bruciava l'erbetta
creando un'essenza alquanto sospetta;
sembrava l'odore di una sacrestia
ma presto mi accorsi che era maria.

             reply	other threads:[~2007-07-07 23:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-07 23:33 Luca Tettamanti [this message]
2007-07-09 15:46 ` Bjorn Helgaas
2007-07-09 17:30   ` Luca
2007-07-09 18:30     ` Bjorn Helgaas
2007-07-11 19:40       ` Luca
2007-07-11 21:07         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070707233300.GA3267@dreamland.darkstar.lan \
    --to=kronos.it@gmail.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®