mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: amlogic: gx pm domain: add PM and OF dependencies
Date: Fri, 3 Nov 2017 15:59:23 +0100	[thread overview]
Message-ID: <68709b1d-4c16-dc8b-e315-d1e4bb10b6f2@baylibre.com> (raw)
In-Reply-To: <20171102224256.1686675-1-arnd@arndb.de>

On 02/11/2017 23:42, Arnd Bergmann wrote:
> The new driver introduces harmless warnings:
> 
> warning: (PM_RMOBILE && ARCH_RCAR_GEN1 && ARCH_RCAR_GEN2 && ARCH_R7S72100 && MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
> warning: (MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
> 
> This adds CONFIG_OF and CONFIG_PM dependencies to ensure it
> will only be enabled in valid configurations.
> 
> Fixes: 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/soc/amlogic/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig
> index 1621bb25a1ea..b04f6e4aedbc 100644
> --- a/drivers/soc/amlogic/Kconfig
> +++ b/drivers/soc/amlogic/Kconfig
> @@ -12,6 +12,7 @@ config MESON_GX_SOCINFO
>  config MESON_GX_PM_DOMAINS
>  	bool "Amlogic Meson GX Power Domains driver"
>  	depends on ARCH_MESON || COMPILE_TEST
> +	depends on PM && OF
>  	default ARCH_MESON
>  	select PM_GENERIC_DOMAINS
>  	select PM_GENERIC_DOMAINS_OF
> 

Thanks for the fix

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

      reply	other threads:[~2017-11-03 14:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 22:42 Arnd Bergmann
2017-11-03 14:59 ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68709b1d-4c16-dc8b-e315-d1e4bb10b6f2@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=arnd@arndb.de \
    --cc=khilman@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®