mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Salyzyn <salyzyn@android.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
	joe@perches.com, prarit@redhat.com, rjw@rjwysocki.net,
	tglx@linutronix.de, Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Salyzyn <salyzyn@google.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Olof Johansson <olof@lixom.net>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v5] printk: Add pr_info_show_time
Date: Mon, 24 Jul 2017 08:47:38 -0700	[thread overview]
Message-ID: <68db835b-4053-4785-f385-9a455bc505e2@android.com> (raw)
In-Reply-To: <20170722094000.GA8064@xo-6d-61-c0.localdomain>

On 07/22/2017 02:40 AM, Pavel Machek wrote:
>> For example, the persistent clock that is used to report
>> "Suspended for" message, although very useful, is not present on all
>> platforms.  It is currently standardized for millisecond precision.
> Fix that on your platforms, instead?
>
> 								Pavel

lol :-)

That is a _hardware_ issue. For a vast majority of them, the persistent 
read-only clock requires a LTE, always-on ready to wakeup device for a 
phone call, correction factor from a separate driver. In some cases the 
persistent clock requires a hardware re-init sequence to a pmic 
controller that occurs higher up in the resume chain. For those where it 
is possible, please remember there are 25K different Android devices, 
represented in nearly 2B hands. Feel free to tell all the implementors 
just how important a continuously accessible working 100% tuned accurate 
persistent clock is when _this_ _one_ flawed (ms accuracy, no lte 
correction while asleep) print is the only place which gains from said 
access ;-). I am blue in the face just working with the limited set I 
have influence on.

And yet, add a simple print of realtime clock at suspend and resume 
points higher up in the chain always works regardless of the hardware or 
the driver skills of the vendor building the devices.


-- Mark

      reply	other threads:[~2017-07-24 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 18:24 Mark Salyzyn
2017-07-21  0:21 ` Sergey Senozhatsky
2017-07-21  2:00 ` Luis R. Rodriguez
2017-07-21 15:00   ` Mark Salyzyn
2017-07-22  9:40 ` Pavel Machek
2017-07-24 15:47   ` Mark Salyzyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68db835b-4053-4785-f385-9a455bc505e2@android.com \
    --to=salyzyn@android.com \
    --cc=Jason@zx2c4.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=geert@linux-m68k.org \
    --cc=joe@perches.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mingo@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=olof@lixom.net \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=prarit@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=salyzyn@google.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®