From: David Laight <David.Laight@ACULAB.COM>
To: 'Peter Zijlstra' <peterz@infradead.org>,
"x86@kernel.org" <x86@kernel.org>, Borislav Petkov <bp@alien8.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] x86/alternative: Support relocations in alternatives
Date: Wed, 8 Feb 2023 12:29:38 +0000 [thread overview]
Message-ID: <693ce771113d49da92235a0f6d2e395f@AcuMS.aculab.com> (raw)
In-Reply-To: <Y+EXQlGSI9WUU8nn@hirez.programming.kicks-ass.net>
From: Peter Zijlstra
> Sent: 06 February 2023 15:06
...
> +#define apply_reloc_n(n_, p_, d_) \
> + do { \
> + s32 v = *(s##n_ *)(p_); \
You've added '_' suffixes to the parameters.
But these only refer to the body of the #define
so are never a problem.
OTOH the local 'v' will cause confusion if one of the
actual parameters is 'v'.
Which is why it is common to prefix locals with '_'.
(Which doesn't help with recursive expansions.)
Since this is only actually expended in the one .c file
it is unlikely to cause a problem.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-02-08 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:05 Peter Zijlstra
2023-02-07 11:38 ` Kirill A. Shutemov
2023-02-07 16:05 ` Peter Zijlstra
2023-02-08 8:58 ` Peter Zijlstra
2023-02-08 12:29 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693ce771113d49da92235a0f6d2e395f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®