From: Peter Zijlstra <peterz@infradead.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: x86@kernel.org, Borislav Petkov <bp@alien8.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/alternative: Support relocations in alternatives
Date: Tue, 7 Feb 2023 17:05:27 +0100 [thread overview]
Message-ID: <Y+J2x5sPU0uL8bE0@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230207113813.rqwpuaung2hr433q@box.shutemov.name>
On Tue, Feb 07, 2023 at 02:38:13PM +0300, Kirill A. Shutemov wrote:
> > +static void __init_or_module noinline
> > +apply_relocation(u8 *buf, size_t len, u8 *dest, u8 *src, size_t src_len)
> > +{
> > + for (int next, i = 0; i < len; len = next) {
>
> 'len = next'? I guess it suppose to be 'i = next', right? Otherwise it
> hangs for me.
>
Yeah, last minute changes and not testing :/ Sorry about that. I'll try
and post an actually tested patch later today.
Also, Masami, how difficuly would it be to do insn_is_nop() that matches
most/all conventional NOP instructions?
That might make it more convenient to write a more generic
optimize_nops_range() -- it currently needs a single byte nop range and
one of the bugs in the patch as posted is caused by a multi-byte nop
(specifically a 0x66 prefixed 0x90).
next prev parent reply other threads:[~2023-02-07 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:05 Peter Zijlstra
2023-02-07 11:38 ` Kirill A. Shutemov
2023-02-07 16:05 ` Peter Zijlstra [this message]
2023-02-08 8:58 ` Peter Zijlstra
2023-02-08 12:29 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+J2x5sPU0uL8bE0@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Andrew.Cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®