mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Cc: alan@redhat.com
Subject: Re: 2.6.13-mm1
Date: Thu, 01 Sep 2005 07:22:53 -0700	[thread overview]
Message-ID: <6970000.1125584568@[10.10.2.4]> (raw)
In-Reply-To: <20050901035542.1c621af6.akpm@osdl.org>


Breaks build on PPC64

Lots of this:

In file included from fs/xfs/linux-2.6/xfs_linux.h:57,
                 from fs/xfs/xfs.h:35,
                 from fs/xfs/xfs_rtalloc.c:37:
fs/xfs/xfs_arch.h:55:21: warning: "__LITTLE_ENDIAN" is not defined
In file included from fs/xfs/xfs_rtalloc.c:50:
fs/xfs/xfs_bmap_btree.h:65:21: warning: "__LITTLE_ENDIAN" is not defined
  CC      fs/xfs/xfs_acl.o
In file included from fs/xfs/linux-2.6/xfs_linux.h:57,
                 from fs/xfs/xfs.h:35,
                 from fs/xfs/xfs_acl.c:33:
fs/xfs/xfs_arch.h:55:21: warning: "__LITTLE_ENDIAN" is not defined

Can't see anything obvious to cause that.
Then this:

CC      drivers/char/hvc_console.o
drivers/char/hvc_console.c: In function `hvc_poll':
drivers/char/hvc_console.c:600: error: `count' undeclared (first use in this function)
drivers/char/hvc_console.c:600: error: (Each undeclared identifier is reported only once
drivers/char/hvc_console.c:600: error: for each function it appears in.)
drivers/char/hvc_console.c:636: error: structure has no member named `flip'
make[2]: *** [drivers/char/hvc_console.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Presumably this:

diff -puN drivers/char/hvc_console.c~tty-layer-buffering-revamp drivers/char/hvc
_console.c
--- 25/drivers/char/hvc_console.c~tty-layer-buffering-revamp    Wed Aug 31 12:50
:55 2005
+++ 25-akpm/drivers/char/hvc_console.c  Wed Aug 31 12:50:56 2005
@@ -597,10 +597,8 @@ static int hvc_poll(struct hvc_struct *h
 
        /* Read data if any */
        for (;;) {
-               int count = N_INBUF;
-               if (count > (TTY_FLIPBUF_SIZE - tty->flip.count))
-                       count = TTY_FLIPBUF_SIZE - tty->flip.count;
-
+               count = tty_buffer_request_room(tty, N_INBUF);
+               
                /* If flip is full, just reschedule a later read */
                if (count == 0) {
                        poll_mask |= HVC_POLL_READ;

shouldn't be deleting the declaration of count. 

and possibly the "flip removal" was incomplete (line 636) ???


  reply	other threads:[~2005-09-01 14:23 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-01 10:55 2.6.13-mm1 Andrew Morton
2005-09-01 14:22 ` Martin J. Bligh [this message]
2005-09-01 14:50   ` 2.6.13-mm1 Alan Cox
2005-09-01 20:56     ` 2.6.13-mm1 Joel Schopp
2005-09-01 21:16       ` 2.6.13-mm1 Alan Cox
2005-09-01 21:26         ` 2.6.13-mm1 Joel Schopp
2005-09-01 21:44           ` 2.6.13-mm1 Alan Cox
2005-09-12 16:34             ` tty patches in 2.6.13-mm3 (was Re: 2.6.13-mm1) serue
2005-09-12 16:55               ` Joel Schopp
2005-09-12 17:04             ` 2.6.13-mm1 serue
2005-09-01 14:59   ` 2.6.13-mm1 Adrian Bunk
2005-09-01 15:01 ` [PATCH] mips: remove typedef from struct flock Yoichi Yuasa
2005-09-01 15:38 ` 2.6.13-mm1 Dominik Karall
2005-09-01 16:09   ` 2.6.13-mm1 John Stoffel
2005-09-01 16:28     ` 2.6.13-mm1 Dominik Karall
2005-09-01 17:34       ` 2.6.13-mm1 John Stoffel
2005-09-01 18:05         ` 2.6.13-mm1 Dominik Karall
2005-09-01 18:27           ` 2.6.13-mm1 John Stoffel
2005-09-01 15:44 ` [PATCH] : struct dentry : place d_hash close to d_parent and d_name to speedup lookups Eric Dumazet
2005-09-01 15:48   ` Eric Dumazet
2005-09-01 17:36     ` Dipankar Sarma
2005-09-01 19:52       ` Eric Dumazet
2005-09-01 17:41 ` 2.6.13-mm1 - drivers/isdn/i4l/isdn_tty broken Damir Perisa
2005-09-01 21:06   ` Alan Cox
2005-09-02  1:05   ` 2.6.13-mm1 - drivers/serial/jsm/jsm_tty broken too Damir Perisa
2005-09-01 21:14 ` 2.6.13-mm1: PCMCIA problem Rafael J. Wysocki
2005-09-01 21:28   ` Andrew Morton
2005-09-02  8:30     ` Rafael J. Wysocki
2005-09-02  8:37       ` Rafael J. Wysocki
2005-09-02 10:43         ` Pavel Machek
2005-09-02 10:58           ` Rafael J. Wysocki
2005-09-02 11:09           ` Andrew Morton
2005-09-02 11:45             ` 2.6.13-mm1: swsusp problem (was: PCMCIA problem) Rafael J. Wysocki
2005-09-02 14:17               ` Rafael J. Wysocki
2005-09-04 14:29             ` 2.6.13-mm1: PCMCIA problem Pavel Machek
2005-09-01 22:19 ` 2.6.13-mm1: broken drivers/video/sis/Makefile Adrian Bunk
2005-09-01 23:24   ` Thomas Winischhofer
2005-09-01 23:25 ` 2.6.13-mm1: misc mwave issues Adrian Bunk
2005-09-02 12:36   ` Alan Cox
2005-09-02 13:57 ` 2.6.13-mm1 Benjamin LaHaise
2005-09-02 20:57   ` 2.6.13-mm1 Andrew Morton
2005-09-06 11:50     ` 2.6.13-mm1 Benjamin LaHaise
2005-09-02 14:30 ` 2.6.13-mm1 Alexander Nyberg
2005-09-02 14:40   ` 2.6.13-mm1 Zwane Mwaikambo
2005-09-03 12:21 ` 2.6.13-mm1 Adrian Bunk
2005-09-03 19:34   ` 2.6.13-mm1 Andrew Morton
2005-09-03 19:54     ` 2.6.13-mm1 Adrian Bunk
2005-09-03 20:06       ` 2.6.13-mm1 Andrew Morton
2005-09-04 20:00         ` 2.6.13-mm1 Adrian Bunk
2005-09-04 21:24         ` 2.6.13-mm1 Jesper Juhl
2005-09-04 21:30           ` 2.6.13-mm1 Andrew Morton
2005-09-04 21:36             ` 2.6.13-mm1 Jesper Juhl
2005-09-07  0:05             ` 2.6.13-mm1 Paul Jackson
2005-09-07  0:32               ` 2.6.13-mm1 Andrew Morton
2005-09-07  0:44               ` 2.6.13-mm1 Jesper Juhl
2005-09-07  2:38                 ` 2.6.13-mm1 Paul Jackson
2005-09-04 10:26 ` 2.6.13-mm1 Alexander Nyberg
2005-09-01 18:21 2.6.13-mm1 J.A. Magallon
2005-09-01 22:00 ` 2.6.13-mm1 Adrian Bunk
     [not found] <fa.hqupr0d.1u3af35@ifi.uio.no>
2005-09-02  1:39 ` 2.6.13-mm1 Reuben Farrelly
2005-09-02  1:56   ` 2.6.13-mm1 J.A. Magallon
2005-09-02  2:06     ` 2.6.13-mm1 Andrew Morton
2005-09-02 15:53       ` 2.6.13-mm1 J.A. Magallon
2005-09-02 21:45         ` 2.6.13-mm1 Andrew Morton
2005-09-02 22:55           ` 2.6.13-mm1 J.A. Magallon
2005-09-03  0:15           ` 2.6.13-mm1 gcoady
2005-09-02  2:04   ` 2.6.13-mm1 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='6970000.1125584568@[10.10.2.4]' \
    --to=mbligh@mbligh.org \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®