From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH v3 3/3] tools headers: Don't check arm64's unistd.h
Date: Wed, 24 Dec 2025 13:51:33 +0000 [thread overview]
Message-ID: <69a098d8-ff54-4746-96d5-5ce5eb2a8a83@linaro.org> (raw)
In-Reply-To: <20251222-perf_fix_syscall_header-v3-3-eb4a8b9dfe66@arm.com>
On 22/12/2025 6:06 pm, Leo Yan wrote:
> The arm64 unistd.h in tools now diverges from the kernel header.
> Comparing the two headers is pointless, remove the check.
>
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
> tools/perf/check-headers.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index e0537f275da2f79ea9e05b91300aa1e2f996e9f1..da3aca87457fdc56c96d4184f2dee88dab026d98 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -54,7 +54,6 @@ declare -a FILES=(
> "arch/s390/include/uapi/asm/kvm.h"
> "arch/s390/include/uapi/asm/sie.h"
> "arch/arm64/include/uapi/asm/kvm.h"
> - "arch/arm64/include/uapi/asm/unistd.h"
Isn't this _more_ of a special case for arm64 than continuing to do the
consistency check like in v2? It seems like the desire for consistency
isn't taking the whole tools/ picture into account and we end up adding
more inconsistencies than just the regular static copy + diff check that
we have for all the other headers.
> "arch/alpha/include/uapi/asm/errno.h"
> "arch/mips/include/asm/errno.h"
> "arch/mips/include/uapi/asm/errno.h"
>
next prev parent reply other threads:[~2025-12-24 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 18:06 [PATCH v3 0/3] tools build: Fix arm64 unistd.h dependency Leo Yan
2025-12-22 18:06 ` [PATCH v3 1/3] tools headers: Go back to include asm-generic/unistd.h for arm64 Leo Yan
2025-12-24 13:47 ` James Clark
2026-01-07 14:48 ` Leo Yan
2026-01-07 15:21 ` Arnd Bergmann
2026-01-07 17:14 ` Leo Yan
2025-12-22 18:06 ` [PATCH v3 2/3] Revert "perf tools: Fix arm64 build by generating unistd_64.h" Leo Yan
2025-12-22 18:06 ` [PATCH v3 3/3] tools headers: Don't check arm64's unistd.h Leo Yan
2025-12-24 13:51 ` James Clark [this message]
2026-01-07 15:05 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a098d8-ff54-4746-96d5-5ce5eb2a8a83@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®