* [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan
@ 2024-10-03 2:18 syzbot
2024-12-19 8:16 ` syzbot
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: syzbot @ 2024-10-03 2:18 UTC (permalink / raw)
To: jlbec, joseph.qi, linux-kernel, mark, ocfs2-devel, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: f23aa4c0761a Merge tag 'hid-for-linus-2024090201' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1037e580580000
kernel config: https://syzkaller.appspot.com/x/.config?x=f8af0b3195caed62
dashboard link: https://syzkaller.appspot.com/bug?extid=78359d5fbb04318c35e9
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98e7ebb9603f/disk-f23aa4c0.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2b99ed3c1261/vmlinux-f23aa4c0.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9c2b8860052e/bzImage-f23aa4c0.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+78359d5fbb04318c35e9@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.12.0-rc1-syzkaller-00042-gf23aa4c0761a #0 Not tainted
------------------------------------------------------
syz.1.311/8974 is trying to acquire lock:
ffff88805d22c2c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline]
ffff88805d22c2c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2726
but task is already holding lock:
ffff88805d0dbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2321 [inline]
ffff88805d0dbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x44a/0x1250 fs/ocfs2/aops.c:2427
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
ocfs2_create_local_dquot+0x1de/0x1d70 fs/ocfs2/quota_local.c:1231
ocfs2_acquire_dquot+0x833/0xb80 fs/ocfs2/quota_global.c:878
dqget+0x770/0xeb0 fs/quota/dquot.c:976
__dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1504
ocfs2_get_init_inode+0x158/0x1c0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xcfa/0x2b40 fs/ocfs2/namei.c:308
ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655
vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257
do_mkdirat+0x264/0x3a0 fs/namei.c:4280
__do_sys_mkdir fs/namei.c:4300 [inline]
__se_sys_mkdir fs/namei.c:4298 [inline]
__x64_sys_mkdir+0x6c/0x80 fs/namei.c:4298
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
wait_on_dquot fs/quota/dquot.c:355 [inline]
dqget+0x6e6/0xeb0 fs/quota/dquot.c:971
__dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1504
ocfs2_get_init_inode+0x158/0x1c0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xcfa/0x2b40 fs/ocfs2/namei.c:308
ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655
vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257
do_mkdirat+0x264/0x3a0 fs/namei.c:4280
__do_sys_mkdir fs/namei.c:4300 [inline]
__se_sys_mkdir fs/namei.c:4298 [inline]
__x64_sys_mkdir+0x6c/0x80 fs/namei.c:4298
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
inode_lock include/linux/fs.h:815 [inline]
ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
ocfs2_evict_inode+0x209f/0x4680 fs/ocfs2/inode.c:1216
evict+0x4e8/0x9b0 fs/inode.c:723
d_delete_notify include/linux/fsnotify.h:332 [inline]
vfs_rmdir+0x3d7/0x510 fs/namei.c:4353
do_rmdir+0x3b5/0x580 fs/namei.c:4399
__do_sys_unlinkat fs/namei.c:4575 [inline]
__se_sys_unlinkat fs/namei.c:4569 [inline]
__x64_sys_unlinkat+0xde/0xf0 fs/namei.c:4569
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
__lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
inode_lock include/linux/fs.h:815 [inline]
ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2726
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2329 [inline]
ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2427
dio_complete+0x251/0x6b0 fs/direct-io.c:281
__blockdev_direct_IO+0x3ebd/0x4890 fs/direct-io.c:1303
ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464
generic_file_direct_write+0x17a/0x390 mm/filemap.c:3977
__generic_file_write_iter+0x126/0x230 mm/filemap.c:4141
ocfs2_file_write_iter+0x17b1/0x1f50 fs/ocfs2/file.c:2456
do_iter_readv_writev+0x600/0x880
vfs_writev+0x376/0xba0 fs/read_write.c:1064
do_pwritev fs/read_write.c:1165 [inline]
__do_sys_pwritev2 fs/read_write.c:1224 [inline]
__se_sys_pwritev2+0x1ca/0x2d0 fs/read_write.c:1215
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Chain exists of:
&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&dquot->dq_lock);
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
*** DEADLOCK ***
3 locks held by syz.1.311/8974:
#0: ffff888031bd2420 (sb_writers#14){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2931 [inline]
#0: ffff888031bd2420 (sb_writers#14){.+.+}-{0:0}, at: vfs_writev+0x2d1/0xba0 fs/read_write.c:1062
#1: ffff88805d0dc2c0 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline]
#1: ffff88805d0dc2c0 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x467/0x1f50 fs/ocfs2/file.c:2388
#2: ffff88805d0dbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2321 [inline]
#2: ffff88805d0dbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x44a/0x1250 fs/ocfs2/aops.c:2427
stack backtrace:
CPU: 0 UID: 0 PID: 8974 Comm: syz.1.311 Not tainted 6.12.0-rc1-syzkaller-00042-gf23aa4c0761a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
__lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
inode_lock include/linux/fs.h:815 [inline]
ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2726
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2329 [inline]
ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2427
dio_complete+0x251/0x6b0 fs/direct-io.c:281
__blockdev_direct_IO+0x3ebd/0x4890 fs/direct-io.c:1303
ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464
generic_file_direct_write+0x17a/0x390 mm/filemap.c:3977
__generic_file_write_iter+0x126/0x230 mm/filemap.c:4141
ocfs2_file_write_iter+0x17b1/0x1f50 fs/ocfs2/file.c:2456
do_iter_readv_writev+0x600/0x880
vfs_writev+0x376/0xba0 fs/read_write.c:1064
do_pwritev fs/read_write.c:1165 [inline]
__do_sys_pwritev2 fs/read_write.c:1224 [inline]
__se_sys_pwritev2+0x1ca/0x2d0 fs/read_write.c:1215
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f56b9d7dff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f56bac44038 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007f56b9f35f80 RCX: 00007f56b9d7dff9
RDX: 0000000000000002 RSI: 0000000020000240 RDI: 0000000000000005
RBP: 00007f56b9df0296 R08: 0000000000041001 R09: 0000000000000003
R10: 0000000000001200 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f56b9f35f80 R15: 00007fff80cd2c88
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
@ 2024-12-19 8:16 ` syzbot
2026-01-06 11:30 ` Syzbot test for ocfs2: Fix " Prithvi Tambewagh
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2024-12-19 8:16 UTC (permalink / raw)
To: jlbec, joseph.qi, linux-kernel, mark, ocfs2-devel, syzkaller-bugs
syzbot has found a reproducer for the following issue on:
HEAD commit: c061cf420ded Merge tag 'trace-v6.13-rc3' of git://git.kern..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=10cc2e0f980000
kernel config: https://syzkaller.appspot.com/x/.config?x=6a2b862bf4a5409f
dashboard link: https://syzkaller.appspot.com/bug?extid=78359d5fbb04318c35e9
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=113277e8580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17bdef44580000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d015858e49d6/disk-c061cf42.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8af783cbffc2/vmlinux-c061cf42.xz
kernel image: https://storage.googleapis.com/syzbot-assets/33b1bb739ed8/bzImage-c061cf42.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/9303ddff3347/mount_0.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+78359d5fbb04318c35e9@syzkaller.appspotmail.com
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc3-syzkaller-00062-gc061cf420ded #0 Not tainted
------------------------------------------------------
syz-executor257/6003 is trying to acquire lock:
ffff88806f6d5100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
ffff88806f6d5100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2728
but task is already holding lock:
ffff888076616a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2321 [inline]
ffff888076616a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io+0x44a/0x1250 fs/ocfs2/aops.c:2427
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
ocfs2_create_local_dquot+0x1de/0x1d70 fs/ocfs2/quota_local.c:1231
ocfs2_acquire_dquot+0x833/0xb70 fs/ocfs2/quota_global.c:878
dqget+0x772/0xeb0 fs/quota/dquot.c:977
__dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505
ocfs2_get_init_inode+0x158/0x1d0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xcfa/0x2b30 fs/ocfs2/namei.c:310
ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:657
vfs_mkdir+0x2fb/0x4f0 fs/namei.c:4311
do_mkdirat+0x264/0x3a0 fs/namei.c:4334
__do_sys_mkdir fs/namei.c:4354 [inline]
__se_sys_mkdir fs/namei.c:4352 [inline]
__x64_sys_mkdir+0x6c/0x80 fs/namei.c:4352
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #2 (&dquot->dq_lock){+.+.}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
__mutex_lock_common kernel/locking/mutex.c:585 [inline]
__mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
wait_on_dquot fs/quota/dquot.c:354 [inline]
dqget+0x6e6/0xeb0 fs/quota/dquot.c:972
__dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505
ocfs2_get_init_inode+0x158/0x1d0 fs/ocfs2/namei.c:202
ocfs2_mknod+0xcfa/0x2b30 fs/ocfs2/namei.c:310
ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:657
vfs_mkdir+0x2fb/0x4f0 fs/namei.c:4311
do_mkdirat+0x264/0x3a0 fs/namei.c:4334
__do_sys_mkdir fs/namei.c:4354 [inline]
__se_sys_mkdir fs/namei.c:4352 [inline]
__x64_sys_mkdir+0x6c/0x80 fs/namei.c:4352
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
inode_lock include/linux/fs.h:818 [inline]
ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
ocfs2_evict_inode+0x209f/0x4630 fs/ocfs2/inode.c:1216
evict+0x4ea/0x9a0 fs/inode.c:796
d_delete_notify include/linux/fsnotify.h:332 [inline]
vfs_rmdir+0x3d7/0x510 fs/namei.c:4407
do_rmdir+0x3b5/0x580 fs/namei.c:4453
__do_sys_unlinkat fs/namei.c:4629 [inline]
__se_sys_unlinkat fs/namei.c:4623 [inline]
__x64_sys_unlinkat+0xde/0xf0 fs/namei.c:4623
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}:
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
__lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
inode_lock include/linux/fs.h:818 [inline]
ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2728
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2329 [inline]
ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2427
dio_complete+0x253/0x6b0 fs/direct-io.c:281
__blockdev_direct_IO+0x3eb6/0x4890 fs/direct-io.c:1303
ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464
generic_file_direct_write+0x1e8/0x400 mm/filemap.c:3978
__generic_file_write_iter+0x126/0x230 mm/filemap.c:4142
ocfs2_file_write_iter+0x19af/0x2180 fs/ocfs2/file.c:2469
new_sync_write fs/read_write.c:586 [inline]
vfs_write+0xaed/0xd30 fs/read_write.c:679
ksys_write+0x18f/0x2b0 fs/read_write.c:731
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Chain exists of:
&ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&dquot->dq_lock);
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
*** DEADLOCK ***
3 locks held by syz-executor257/6003:
#0: ffff88807cfd6420 (sb_writers#9){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2964 [inline]
#0: ffff88807cfd6420 (sb_writers#9){.+.+}-{0:0}, at: vfs_write+0x225/0xd30 fs/read_write.c:675
#1: ffff888076616d80 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
#1: ffff888076616d80 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x445/0x2180 fs/ocfs2/file.c:2399
#2: ffff888076616a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2321 [inline]
#2: ffff888076616a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io+0x44a/0x1250 fs/ocfs2/aops.c:2427
stack backtrace:
CPU: 0 UID: 0 PID: 6003 Comm: syz-executor257 Not tainted 6.13.0-rc3-syzkaller-00062-gc061cf420ded #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
__lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
down_write+0x99/0x220 kernel/locking/rwsem.c:1577
inode_lock include/linux/fs.h:818 [inline]
ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2728
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2329 [inline]
ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2427
dio_complete+0x253/0x6b0 fs/direct-io.c:281
__blockdev_direct_IO+0x3eb6/0x4890 fs/direct-io.c:1303
ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464
generic_file_direct_write+0x1e8/0x400 mm/filemap.c:3978
__generic_file_write_iter+0x126/0x230 mm/filemap.c:4142
ocfs2_file_write_iter+0x19af/0x2180 fs/ocfs2/file.c:2469
new_sync_write fs/read_write.c:586 [inline]
vfs_write+0xaed/0xd30 fs/read_write.c:679
ksys_write+0x18f/0x2b0 fs/read_write.c:731
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f84076eb969
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe891e4fb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f84076eb969
RDX: 000000000000f000 RSI: 0000000020000200 RDI: 0000000000000006
RBP: 0000000000000000 R08: 00007ffe891e4d57 R09: 00007ffe891e4fec
R10: 0000000000000012 R11: 0000000000000246 R12: 00007ffe891e4fec
R13: 000000000000002b R14: 431bde82d7b634db R15: 00007ffe891e5020
</TASK>
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Syzbot test for ocfs2: Fix deadlock in ocfs2_del_inode_from_orphan
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
2024-12-19 8:16 ` syzbot
@ 2026-01-06 11:30 ` Prithvi Tambewagh
2026-01-06 11:59 ` [syzbot] [ocfs2?] possible " syzbot
2026-02-23 3:38 ` Forwarded: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction syzbot
` (4 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Prithvi Tambewagh @ 2026-01-06 11:30 UTC (permalink / raw)
To: syzbot+78359d5fbb04318c35e9, jlbec, joseph.qi, mark
Cc: heming.zhao, linux-kernel, ocfs2-devel, syzkaller-bugs,
Prithvi Tambewagh
#syz test upstream 765e56e41a5af2d456ddda6cbd617b9d3295ab4e
Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
fs/ocfs2/aops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 76c86f1c2b1c..586e3b74d782 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -2295,8 +2295,6 @@ static int ocfs2_dio_end_io_write(struct inode *inode,
goto out;
}
- down_write(&oi->ip_alloc_sem);
-
/* Delete orphan before acquire i_rwsem. */
if (dwc->dw_orphaned) {
BUG_ON(dwc->dw_writer_pid != task_pid_nr(current));
@@ -2309,6 +2307,8 @@ static int ocfs2_dio_end_io_write(struct inode *inode,
mlog_errno(ret);
}
+ down_write(&oi->ip_alloc_sem);
+
di = (struct ocfs2_dinode *)di_bh->b_data;
ocfs2_init_dinode_extent_tree(&et, INODE_CACHE(inode), di_bh);
base-commit: 765e56e41a5af2d456ddda6cbd617b9d3295ab4e
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan
2026-01-06 11:30 ` Syzbot test for ocfs2: Fix " Prithvi Tambewagh
@ 2026-01-06 11:59 ` syzbot
0 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2026-01-06 11:59 UTC (permalink / raw)
To: activprithvi, heming.zhao, jlbec, joseph.qi, linux-kernel, mark,
ocfs2-devel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-by: syzbot+78359d5fbb04318c35e9@syzkaller.appspotmail.com
Tested-by: syzbot+78359d5fbb04318c35e9@syzkaller.appspotmail.com
Tested on:
commit: 765e56e4 Merge tag 'v6.18rc7-SMB-client-fix' of git://..
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=1723be9a580000
kernel config: https://syzkaller.appspot.com/x/.config?x=38a0c4cddc846161
dashboard link: https://syzkaller.appspot.com/bug?extid=78359d5fbb04318c35e9
compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch: https://syzkaller.appspot.com/x/patch.diff?x=107b8044580000
Note: testing is done by a robot and is best-effort only.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Forwarded: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
2024-12-19 8:16 ` syzbot
2026-01-06 11:30 ` Syzbot test for ocfs2: Fix " Prithvi Tambewagh
@ 2026-02-23 3:38 ` syzbot
2026-02-23 4:31 ` syzbot
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2026-02-23 3:38 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction
Author: activprithvi@gmail.com
#syz test: upstream c22e26bd0906e9c8325462993f01adb16b8ea2c0
Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
fs/ocfs2/aops.c | 5 +++++
fs/ocfs2/inode.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 586e3b74d782..d706ebd95260 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -2420,6 +2420,11 @@ static ssize_t ocfs2_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
struct inode *inode = file->f_mapping->host;
struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
get_block_t *get_block;
+ if (IS_NOQUOTA(inode)) {
+ mlog(ML_ERROR, "Direct IO is not allowed for Quota inode %lu\n",
+ inode->i_ino);
+ return -ENOTSUP;
+ }
/*
* Fallback to buffered I/O if we see an inode without
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index fcc89856ab95..e5d932914b70 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -1266,6 +1266,7 @@ static void ocfs2_clear_inode(struct inode *inode)
"Clear inode of %llu, alloc_sem is locked\n",
(unsigned long long)oi->ip_blkno);
up_write(&oi->ip_alloc_sem);
+ init_rwsem(&oi->ip_alloc_sem);
mlog_bug_on_msg(oi->ip_open_count,
"Clear inode of %llu has open count %d\n",
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Forwarded: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
` (2 preceding siblings ...)
2026-02-23 3:38 ` Forwarded: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction syzbot
@ 2026-02-23 4:31 ` syzbot
2026-02-24 5:28 ` Forwarded: test patch syzbot
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2026-02-23 4:31 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction
Author: activprithvi@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c22e26bd0906e9c8325462993f01adb16b8ea2c0
Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
fs/ocfs2/aops.c | 5 +++++
fs/ocfs2/inode.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 586e3b74d782..54261d7c14fa 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -2420,6 +2420,11 @@ static ssize_t ocfs2_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
struct inode *inode = file->f_mapping->host;
struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
get_block_t *get_block;
+ if (IS_NOQUOTA(inode)) {
+ mlog(ML_ERROR, "Direct IO is not allowed for Quota inode %lu\n",
+ inode->i_ino);
+ return -EPERM;
+ }
/*
* Fallback to buffered I/O if we see an inode without
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index fcc89856ab95..e5d932914b70 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -1266,6 +1266,7 @@ static void ocfs2_clear_inode(struct inode *inode)
"Clear inode of %llu, alloc_sem is locked\n",
(unsigned long long)oi->ip_blkno);
up_write(&oi->ip_alloc_sem);
+ init_rwsem(&oi->ip_alloc_sem);
mlog_bug_on_msg(oi->ip_open_count,
"Clear inode of %llu has open count %d\n",
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Forwarded: test patch
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
` (3 preceding siblings ...)
2026-02-23 4:31 ` syzbot
@ 2026-02-24 5:28 ` syzbot
2026-02-24 6:35 ` syzbot
2026-03-02 5:31 ` syzbot
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2026-02-24 5:28 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: test patch
Author: heming.zhao@suse.com
#syz test
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c
index de7f12858729..b7555aff169e 100644
--- a/fs/ocfs2/quota_local.c
+++ b/fs/ocfs2/quota_local.c
@@ -1224,7 +1224,10 @@ int ocfs2_create_local_dquot(struct dquot *dquot)
int status;
u64 pcount;
- down_write(&OCFS2_I(lqinode)->ip_alloc_sem);
+ if (!down_write_trylock(&OCFS2_I(lqinode)->ip_alloc_sem)) {
+ status = -EBUSY;
+ goto out;
+ }
chunk = ocfs2_find_free_entry(sb, type, &offset);
if (!chunk) {
chunk = ocfs2_extend_local_quota_file(sb, type, &offset);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Forwarded: test patch
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
` (4 preceding siblings ...)
2026-02-24 5:28 ` Forwarded: test patch syzbot
@ 2026-02-24 6:35 ` syzbot
2026-03-02 5:31 ` syzbot
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2026-02-24 6:35 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: test patch
Author: heming.zhao@suse.com
#syz test
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c
index e85b1ccf81be..4321d8f59402 100644
--- a/fs/ocfs2/quota_global.c
+++ b/fs/ocfs2/quota_global.c
@@ -311,7 +311,10 @@ int ocfs2_lock_global_qf(struct ocfs2_mem_dqinfo *oinfo, int ex)
spin_unlock(&dq_data_lock);
if (ex) {
inode_lock(oinfo->dqi_gqinode);
- down_write(&OCFS2_I(oinfo->dqi_gqinode)->ip_alloc_sem);
+ if (!down_write_trylock(&OCFS2_I(oinfo->dqi_gqinode)->ip_alloc_sem)) {
+ inode_unlock(oinfo->dqi_gqinode);
+ return -EBUSY;
+ }
} else {
down_read(&OCFS2_I(oinfo->dqi_gqinode)->ip_alloc_sem);
}
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c
index de7f12858729..b7555aff169e 100644
--- a/fs/ocfs2/quota_local.c
+++ b/fs/ocfs2/quota_local.c
@@ -1224,7 +1224,10 @@ int ocfs2_create_local_dquot(struct dquot *dquot)
int status;
u64 pcount;
- down_write(&OCFS2_I(lqinode)->ip_alloc_sem);
+ if (!down_write_trylock(&OCFS2_I(lqinode)->ip_alloc_sem)) {
+ status = -EBUSY;
+ goto out;
+ }
chunk = ocfs2_find_free_entry(sb, type, &offset);
if (!chunk) {
chunk = ocfs2_extend_local_quota_file(sb, type, &offset);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Forwarded: test patch
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
` (5 preceding siblings ...)
2026-02-24 6:35 ` syzbot
@ 2026-03-02 5:31 ` syzbot
6 siblings, 0 replies; 9+ messages in thread
From: syzbot @ 2026-03-02 5:31 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: test patch
Author: heming.zhao@suse.com
#syz test
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c
index e85b1ccf81be..77b8f0363e94 100644
--- a/fs/ocfs2/quota_global.c
+++ b/fs/ocfs2/quota_global.c
@@ -311,11 +311,25 @@ int ocfs2_lock_global_qf(struct ocfs2_mem_dqinfo *oinfo, int ex)
spin_unlock(&dq_data_lock);
if (ex) {
inode_lock(oinfo->dqi_gqinode);
- down_write(&OCFS2_I(oinfo->dqi_gqinode)->ip_alloc_sem);
+ if (!down_write_trylock(&OCFS2_I(oinfo->dqi_gqinode)->ip_alloc_sem)) {
+ inode_unlock(oinfo->dqi_gqinode);
+ status = -EBUSY;
+ goto bail;
+ }
} else {
down_read(&OCFS2_I(oinfo->dqi_gqinode)->ip_alloc_sem);
}
return 0;
+
+bail:
+ /* does a similar job as ocfs2_unlock_global_qf */
+ ocfs2_inode_unlock(oinfo->dqi_gqinode, ex);
+ brelse(oinfo->dqi_gqi_bh);
+ spin_lock(&dq_data_lock);
+ if (!--oinfo->dqi_gqi_count)
+ oinfo->dqi_gqi_bh = NULL;
+ spin_unlock(&dq_data_lock);
+ return status;
}
void ocfs2_unlock_global_qf(struct ocfs2_mem_dqinfo *oinfo, int ex)
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c
index c4e0117d8977..e749cd064c87 100644
--- a/fs/ocfs2/quota_local.c
+++ b/fs/ocfs2/quota_local.c
@@ -1224,7 +1224,9 @@ int ocfs2_create_local_dquot(struct dquot *dquot)
int status;
u64 pcount;
- down_write(&OCFS2_I(lqinode)->ip_alloc_sem);
+ if (!down_write_trylock(&OCFS2_I(lqinode)->ip_alloc_sem))
+ return -EBUSY;
+
chunk = ocfs2_find_free_entry(sb, type, &offset);
if (!chunk) {
chunk = ocfs2_extend_local_quota_file(sb, type, &offset);
--
2.43.0
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-03-02 5:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-03 2:18 [syzbot] [ocfs2?] possible deadlock in ocfs2_del_inode_from_orphan syzbot
2024-12-19 8:16 ` syzbot
2026-01-06 11:30 ` Syzbot test for ocfs2: Fix " Prithvi Tambewagh
2026-01-06 11:59 ` [syzbot] [ocfs2?] possible " syzbot
2026-02-23 3:38 ` Forwarded: Syzbot test for v2: ocfs2: clear lock identity upon inode eviction syzbot
2026-02-23 4:31 ` syzbot
2026-02-24 5:28 ` Forwarded: test patch syzbot
2026-02-24 6:35 ` syzbot
2026-03-02 5:31 ` syzbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®