From: Alejandro Colomar <alx@kernel.org>
To: linux-hardening@vger.kernel.org
Cc: Alejandro Colomar <alx@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andreas Schwab <schwab@linux-m68k.org>,
Andy Shevchenko <andy@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Danilo Krummrich <dakr@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Joe Perches <joe@perches.com>, Johan Hovold <johan@kernel.org>,
Kees Cook <kees@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Len Brown <lenb@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linus Walleij <linusw@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Saravana Kannan <saravanak@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <zanussi@kernel.org>,
linux-acpi@vger.kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org,
David Laight <david.laight.linux@gmail.com>
Subject: [PATCH v4 6/6] string: Make strprefix() const-qualifier-generic
Date: Wed, 11 Nov 2026 20:55:55 +0100 [thread overview]
Message-ID: <69d1792e5edf91eed8cf99745cc840ad954cc3ea.1794425425.git.alx@kernel.org> (raw)
In-Reply-To: <cover.1794425425.git.alx@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]
Add a macro of the same name, which returns a pointer that is
const-qualified iff the input string is const-qualified. The return
type is a possibly-const-qualified pointer to char, even if the input
is a possibly-const-qualified pointer to void, which is why we require
the CQChar_of() macro.
The function now needs to return 'const char *', because const_cast()
can only drop const, but never add it.
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Joe Perches <joe@perches.com>
Cc: David Laight <david.laight.linux@gmail.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---
include/linux/string.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/string.h b/include/linux/string.h
index 168ab1b1fc38..c37041ee089a 100644
--- a/include/linux/string.h
+++ b/include/linux/string.h
@@ -590,11 +590,12 @@ void memcpy_and_pad(void *dest, size_t dest_len, const void *src, size_t count,
* * @s+strlen(@prefix) if @s starts with @prefix
* * NULL if @s does not start with @prefix
*/
-static inline char *strprefix(const char *s, const char *prefix)
+static inline const char *strprefix(const char *s, const char *prefix)
{
size_t len = strlen(prefix);
- return strncmp(s, prefix, len) == 0 ? (char *) s + len : NULL;
+ return strncmp(s, prefix, len) == 0 ? s + len : NULL;
}
+#define strprefix(s, pfx) const_cast(CQChar_of(s) *, strprefix(s, pfx))
/**
* str_has_prefix - Test if a string has a given prefix
--
2.55.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-11-11 19:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 11:12 [PATCH v1 0/2] Add strprefix() and fix a bug with it Alejandro Colomar
2026-11-05 11:13 ` [PATCH v1 1/2] string: Add strprefix(), and deprecate str_has_prefix() Alejandro Colomar
2026-11-05 11:27 ` Andy Shevchenko
2026-11-05 12:28 ` Alejandro Colomar
2026-11-05 16:14 ` Steven Rostedt
2026-11-05 16:33 ` Alejandro Colomar
2026-11-05 16:50 ` Steven Rostedt
2026-11-05 17:46 ` Alejandro Colomar
2026-11-05 18:08 ` Andy Shevchenko
2026-11-05 18:12 ` Andy Shevchenko
2026-11-05 21:24 ` Alejandro Colomar
2026-11-05 21:48 ` Linus Torvalds
2026-11-05 22:25 ` Alejandro Colomar
2026-11-05 23:21 ` Linus Torvalds
2026-11-06 0:01 ` Alejandro Colomar
2026-11-06 7:15 ` Krzysztof Kozlowski
2026-11-05 11:13 ` [PATCH v1 2/2] device property: Fix fwnode_name_eq() for empty node names Alejandro Colomar
2026-11-05 11:24 ` [PATCH v1 0/2] Add strprefix() and fix a bug with it Andy Shevchenko
2026-11-05 11:38 ` Alejandro Colomar
2026-11-05 11:59 ` Andy Shevchenko
2026-11-05 12:30 ` Bartosz Golaszewski
2026-11-05 12:49 ` Alejandro Colomar
2026-11-05 12:46 ` [PATCH v2 " Alejandro Colomar
2026-11-05 12:46 ` [PATCH v2 1/2] string: Add strprefix(), and deprecate str_has_prefix() Alejandro Colomar
2026-11-05 12:51 ` Geert Uytterhoeven
2026-11-05 13:12 ` Alejandro Colomar
2026-11-07 2:44 ` Maciej W. Rozycki
2026-11-07 7:33 ` Alejandro Colomar
2026-11-08 11:05 ` Maciej W. Rozycki
2026-11-08 11:49 ` Alejandro Colomar
2026-11-08 11:54 ` Alejandro Colomar
2026-11-09 22:36 ` Andy Shevchenko
2026-11-05 12:46 ` [PATCH v2 2/2] device property: Fix fwnode_name_eq() for empty node names Alejandro Colomar
2026-11-05 14:01 ` [PATCH v2 0/2] Add strprefix() and fix a bug with it Bartosz Golaszewski
2026-11-05 14:16 ` Alejandro Colomar
2026-11-05 14:42 ` Andy Shevchenko
2026-11-05 15:06 ` Alejandro Colomar
2026-11-07 2:42 ` Maciej W. Rozycki
2026-11-07 14:05 ` Andy Shevchenko
2026-11-05 15:00 ` Bartosz Golaszewski
2026-11-05 15:14 ` Alejandro Colomar
2026-11-05 15:21 ` Krzysztof Kozlowski
2026-11-05 16:27 ` Steven Rostedt
2026-11-05 16:30 ` Krzysztof Kozlowski
2026-11-05 16:42 ` Alejandro Colomar
2026-11-11 19:55 ` [PATCH v4 0/6] " Alejandro Colomar
2026-11-11 19:55 ` [PATCH v4 1/6] string: Add strprefix(), and deprecate str_has_prefix() Alejandro Colomar
2026-11-11 19:55 ` [PATCH v4 2/6] string: Warn if the prefix is the empty string Alejandro Colomar
2026-11-11 19:55 ` [PATCH v4 3/6] device property: Fix fwnode_name_eq() for empty node names Alejandro Colomar
2026-11-11 19:55 ` [PATCH v4 4/6] stddef: Add const_cast() Alejandro Colomar
2026-11-11 20:18 ` Alejandro Colomar
2026-11-11 19:55 ` [PATCH v4 5/6] string: Add [C]QChar_of() and QVoid_of() Alejandro Colomar
2026-11-11 19:55 ` Alejandro Colomar [this message]
2026-11-11 19:57 ` [PATCH v4 0/6] Add strprefix() and fix a bug with it Alejandro Colomar
2026-11-11 20:07 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69d1792e5edf91eed8cf99745cc840ad954cc3ea.1794425425.git.alx@kernel.org \
--to=alx@kernel.org \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=kees@kernel.org \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=namhyung@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=saravanak@kernel.org \
--cc=schwab@linux-m68k.org \
--cc=torvalds@linux-foundation.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®