mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Joel Fernandes (Google.)" <joelaf@google.com>,
	linux-kernel@vger.kernel.org,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Patrick Bellasi <patrick.bellasi@arm.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Luca Abeni <luca.abeni@santannapisa.it>,
	Todd Kjos <tkjos@google.com>,
	claudio@evidence.eu.com, kernel-team@android.com,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked
Date: Wed, 23 May 2018 02:42:32 -0700	[thread overview]
Message-ID: <6A76301E-E383-439D-AD1E-6DC2B2CAC3CE@joelfernandes.org> (raw)
In-Reply-To: <20180523090101.6xifikvjpirqafox@vireshk-i7>



On May 23, 2018 2:01:01 AM PDT, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>On 22-05-18, 15:09, Joel Fernandes wrote:
>> I agree with the race you describe for single policy slow-switch.
>Good find :)
>> 
>> The mainline sugov_work could also do such reordering in sugov_work,
>I think. Even
>> with the mutex_unlock in mainline's sugov_work, that work_in_progress
>write could
>> be reordered by the CPU to happen before the read of next_freq. AIUI,
>> mutex_unlock is expected to be only a release-barrier.
>> 
>> Although to be safe, I could just put an smp_mb() there. I believe
>with that,
>> no locking would be needed for such case.
>> 
>> I'll send out a v3 with Acks for the original patch, and the send out
>the
>> smp_mb() as a separate patch if that's Ok.
>
>Maybe it would be better to get the fix (with smp_mb) first and then
>this optimization patch on the top? That would mean that the fix can
>get applied to stable kernels easily.

Probably. But then Rafael is changing single policy to use the lock so then barrier wouldn't be needed at all. In that case, both mine and Rafael new patch can go into stable which handles your race ( optimization == fix in this case :P )

thanks,

- Joel

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

  reply	other threads:[~2018-05-23  9:42 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 18:55 Joel Fernandes (Google.)
2018-05-18 21:13 ` Saravana Kannan
2018-05-18 21:17   ` Rafael J. Wysocki
2018-05-21  5:14 ` Viresh Kumar
2018-05-21  8:29   ` Rafael J. Wysocki
2018-05-21  9:57     ` Juri Lelli
2018-05-21 16:13     ` Joel Fernandes
2018-05-22 10:02       ` Rafael J. Wysocki
2018-05-22 11:26         ` Rafael J. Wysocki
2018-05-22 15:30         ` Rafael J. Wysocki
2018-05-22 17:07           ` Rafael J. Wysocki
2018-05-21 10:50 ` Patrick Bellasi
2018-05-21 15:49   ` Joel Fernandes
2018-05-21 17:00     ` Patrick Bellasi
2018-05-21 17:20       ` Joel Fernandes
2018-05-21 17:41         ` Patrick Bellasi
2018-05-22 10:23         ` Viresh Kumar
2018-05-22 10:38           ` Patrick Bellasi
2018-05-21 18:05   ` Joel Fernandes
2018-05-22 10:26     ` Patrick Bellasi
2018-05-22 10:34 ` Viresh Kumar
2018-05-22 10:50   ` Viresh Kumar
2018-05-22 10:50     ` Rafael J. Wysocki
2018-05-22 10:54       ` Viresh Kumar
2018-05-22 11:31         ` Rafael J. Wysocki
2018-05-22 11:38           ` Viresh Kumar
2018-05-22 11:42             ` Rafael J. Wysocki
2018-05-22 12:22               ` Rafael J. Wysocki
2018-05-22 15:27                 ` Rafael J. Wysocki
2018-05-22 21:41                   ` Joel Fernandes
2018-05-22 21:52                     ` Rafael J. Wysocki
2018-05-22 22:28                       ` Joel Fernandes
2018-05-22 10:51   ` Patrick Bellasi
2018-05-22 10:56     ` Viresh Kumar
2018-05-22 22:09   ` Joel Fernandes
2018-05-23  8:18     ` Rafael J. Wysocki
2018-05-23  9:01     ` Viresh Kumar
2018-05-23  9:42       ` Joel Fernandes [this message]
2018-05-23 10:06         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6A76301E-E383-439D-AD1E-6DC2B2CAC3CE@joelfernandes.org \
    --to=joel@joelfernandes.org \
    --cc=claudio@evidence.eu.com \
    --cc=joelaf@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luca.abeni@santannapisa.it \
    --cc=mingo@redhat.com \
    --cc=patrick.bellasi@arm.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tkjos@google.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®