Re: [PATCH v3 2/2] ARM: dts: ti/omap: drop unit-address from tpd12s015 endpoints

Re: [PATCH v3 2/2] ARM: dts: ti/omap: drop unit-address from tpd12s015 endpoints

[Quchaosheng]

A gentle ping on 2/2, which nobody has picked up yet.  The binding half
(1/2, dt-bindings: display: ti,tpd12s015) got Rob Herring's Reviewed-by on
09-24; this half is the two-file dts change that drops the unit-address
from the tpd12s015 endpoint nodes on am5729-beagleboneai and am57xx-idk,
and it has been sitting unassigned since 09-16.

Two questions, whichever is easier for you to answer:

  - Should this come through your omap tree, or does it belong with the
    binding, through Tomi and dri-devel?  The two only make sense
    together, since the endpoint nodes carry a unit-address with no
    matching reg property and the new schema rejects that, so they should
    not land separately.
  - If the form is wrong for your tree, tell me what to change and I will
    resend.  If you would rather not carry it, say so and I will drop it.

No urgency on my side - I just do not want it to sit unowned.

Thanks,
Quchaosheng

Re: [PATCH v3 1/2] dt-bindings: display: ti, tpd12s015: Convert to DT schema

[Chaosheng Qu]

Hi Laurent,

You are right, and the two extra entries should not be in the binding.

Both drivers take exactly three GPIOs:

  drivers/gpu/drm/bridge/ti-tpd12s015.c:150,157,164
  drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:237,246,255

They ask for indices 0, 1 and 2 -- CT_CP_HPD, LS_OE and HPD.  Nothing reads
index 3 or 4, and neither file mentions scl, sda or ddc.

The text binding I replaced said the same thing:

  - gpios: CT CP HPD, LS OE and HPD gpios

omap5-igep0050.dts passes two more, and there is no pinctrl group for them
and nothing in-tree consumes them.  v3 raised maxItems to five only so that
dtbs_check would keep passing for that board.  That was the wrong direction:
it wrote a defect of the DT source into the binding instead of holding the
binding to what the hardware and the driver use.

So it splits the way you pointed at earlier:

  - the conversion keeps gpios at three entries, which is what the driver
    requires, and
  - a separate patch drops the two extra entries from omap5-igep0050.dts.

My earlier question still stands: would you rather have that as a v4 from
me, or should I leave it to Eduard's series?

Thanks,
Chaosheng Qu