From: Parth Sane <laerdevstudios@gmail.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
punitvara@gmail.com, stillcompiling@gmail.com,
bhaktipriya96@gmail.com,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c
Date: Wed, 8 Jun 2016 17:07:40 +0530 [thread overview]
Message-ID: <6BD25BE6-1767-43A8-9E48-FC4417ADCE4F@gmail.com> (raw)
In-Reply-To: <57580227.2080400@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt <luisbg@osg.samsung.com> wrote:
>
> On 08/06/16 12:27, Parth Sane wrote:
>> Multiple parenthesis alignment warnings were thrown by checkpatch in ieee80211.c
>> This patch effectively fixes that.
>>
>> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
>>
>> ---
>> drivers/staging/rtl8712/ieee80211.c | 25 ++++++++++++-------------
>> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> Some of the lines you change are over 80 characters. You could fix those as well in
> a second patch :)
>
> Thanks,
> Luis
>
You’re right on that regard. Maybe once this is accepted I can come back to other warnings. I will submit other patches meanwhile.
I seriously want to see this driver in the next release!
Regards,
Parth
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]
next prev parent reply other threads:[~2016-06-08 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 11:27 Parth Sane
2016-06-08 11:31 ` Luis de Bethencourt
2016-06-08 11:37 ` Parth Sane [this message]
[not found] ` <5758064E.6080709@osg.samsung.com>
2016-06-08 11:58 ` Parth Sane
[not found] ` <57580C8B.6040204@osg.samsung.com>
2016-06-08 12:25 ` Parth Sane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6BD25BE6-1767-43A8-9E48-FC4417ADCE4F@gmail.com \
--to=laerdevstudios@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bhaktipriya96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=punitvara@gmail.com \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®