From: Aditya Garg <gargaditya08@live.com>
To: Hector Martin <marcan@marcan.st>
Cc: Ian Lin <ian.lin@infineon.com>,
"alep@cypress.com" <alep@cypress.com>,
"brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
"brcm80211-dev-list@cypress.com" <brcm80211-dev-list@cypress.com>,
"franky.lin@broadcom.com" <franky.lin@broadcom.com>,
"hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"Double.Lo@infineon.com" <Double.Lo@infineon.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Asahi Linux <asahi@lists.linux.dev>
Subject: Re: [PATCH v2 2/4] brcmfmac: Support 89459 pcie
Date: Mon, 2 Jan 2023 09:45:45 +0000 [thread overview]
Message-ID: <6D6035D7-894B-44F6-B35A-3EC9C57029B5@live.com> (raw)
In-Reply-To: <3eb9cc12-db75-8042-4106-fa6521c684a7@marcan.st>
Hi Hector
>
> Is the CYW89459 just a rebrand of the BCM4355, or just a subset? If it
> is a rebrand, it's okay if we call our Apple firmware
> brcmfmac89459-pcie* (note that we use per-board firmware names, so it
> wouldn't conflict with a generic one). However, if CYW89459 only refers
> to specific variants, I think the firmware should be named after the
> overall bcm4355 family.
>
> I'm guessing you intend to ship firmware for this. Would that firmware
> work for all 4355 variants, or only the CYW one? If only the CYW one, is
> it possible to differentiate between them based on PCI revision ID? Note
> that our 4355 has revision ID 12, and Apple specifically calls it 4355C1
> (different chip revisions have different firmware builds, which is why I
> named our firmware brcmfmac4355c1-pcie). If the CYW variant uses other
> revision IDs that do not overlap, maybe we should have different
> firmware entries for them with different masks.
Can we make a separate table for the OTP Apple chips, something like here :-
https://github.com/AdityaGarg8/linux/commit/fc41aac9283d2ba653a8b3191e8c0138c13d8ee1
next prev parent reply other threads:[~2023-01-02 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220922104140.11889-1-ian.lin@infineon.com>
[not found] ` <20220922104140.11889-3-ian.lin@infineon.com>
2022-10-17 12:38 ` Hector Martin
2023-01-02 9:45 ` Aditya Garg [this message]
2023-01-02 13:58 ` Arend van Spriel
2023-01-02 14:01 ` Hector Martin
2023-01-02 14:34 ` Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D6035D7-894B-44F6-B35A-3EC9C57029B5@live.com \
--to=gargaditya08@live.com \
--cc=Double.Lo@infineon.com \
--cc=alep@cypress.com \
--cc=asahi@lists.linux.dev \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=ian.lin@infineon.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®