From: "Jack Wang" <jack_wang@usish.com>
To: "'Xiangliang Yu'" <yuxiangl@marvell.com>,
"'James Bottomley'" <James.Bottomley@HansenPartnership.com>
Cc: <yxlraid@gmail.com>, <lucas.demarchi@profusion.mobi>,
<maciej.trela@intel.com>, <dan.j.williams@intel.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"'Jacky Feng'" <jfeng@marvell.com>
Subject: Re: [PATCH] [SCSI] LIBSAS: fix libsas link error issue
Date: Thu, 16 Jun 2011 16:11:57 +0800 [thread overview]
Message-ID: <6E6072BD03F348168F749B19B2BA90D3@usish.com.cn> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FAE66DB6@SC-VEXCH4.marvell.com>
> >> > >[Jack Wang]
> >> > >I don't think the statement below is error:
> >> > >child->linkrate = min(parent_phy->linkrate, child->max_linkrate);
> >>
> >> The parent_phy is same to child_phy, I don't think it's right.
> >>
> >[Jack Wang] The parent_phy->linkrate is report from DISCOVER response as
> >negotiated link rate(parent phy with child phy), so same is right.
>
> Parent_phy = &parent->ex_dev.ex_phy[phy_id]; (sas_ex_discover_expander)
> struct expander_device *parent_ex = &parent->ex_dev;(sas_ex_get_linkrate)
> struct ex_phy *phy = &parent_ex->ex_phy[i];
> so, parent_phy and phy are same one variable.
>
> >> >> Yes, you can test like this.
> >> >> >Then expander1's linkrate will set to 3G, and expander2's linkrate
> will
> >> set
> >> >> >to 6G, that is correct.
> >> >> yes
> >> >> > But the connection rate will be 3G from hba to
> >> >> >expander2.
> >> >> How to configure the connection rate?
> >> >> Now, MVSAS driver get 6G from sas_ex_get_linkrate function, and set
> >> linkrate
> >> >> of OPEN address frame to the value. right?
> >> >>
> >> >> --
> >> >[Jack Wang]
> >> >Connection rate is auto, link layer will insert deletable primitives
to
> do
> >> >rate matching (sas2r15 7.14).
> >>
> >> >Yes, you should set the linkrate to that value .
> >>
> >> OK.MVSAS driver seem right. But, the problem is command fail because of
> link
> >> error, that is why I commit this patch. And my patch work fine.
> >> You can reproduce the issue and fix it. Thanks!
> >[Jack Wang] I re-consider it , you maybe should compare the HBA linkrate
> >with the child phy linkrate and chose a minor.
>
> Yes, how about this:
> - child->linkrate = min(parent_phy->linkrate, child->max_linkrate);
> + child->linkrate = min(parent->max_linkrate, child->max_linkrate);
> The max link rate of parent have HBA link rate info:
> dev->max_linkrate = port->linkrate; (in sas_get_port_device function).
[Jack Wang]
No, I mean you when you set connection rate in OPEN Address frame, you
compare your HBA linkrate with the linkrate of the phy you want to open, and
chose the minor.
next prev parent reply other threads:[~2011-06-16 8:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 15:17 yxlraid
2011-06-14 15:29 ` James Bottomley
2011-06-15 1:44 ` Xiangliang Yu
2011-06-15 4:15 ` Douglas Gilbert
2011-06-15 4:52 ` Xiangliang Yu
2011-06-15 5:57 ` James Bottomley
2011-06-15 6:31 ` Xiangliang Yu
2011-06-16 1:41 ` Jack Wang
2011-06-16 1:57 ` Xiangliang Yu
2011-06-16 2:18 ` Jack Wang
2011-06-16 2:29 ` Xiangliang Yu
2011-06-16 4:31 ` Jack Wang
2011-06-16 4:53 ` Xiangliang Yu
2011-06-16 6:12 ` Jack Wang
2011-06-16 6:37 ` Xiangliang Yu
2011-06-16 6:55 ` Jack Wang
2011-06-16 7:27 ` Xiangliang Yu
2011-06-16 8:11 ` Jack Wang [this message]
2011-06-16 9:04 ` Xiangliang Yu
2011-06-16 9:33 ` Jack Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E6072BD03F348168F749B19B2BA90D3@usish.com.cn \
--to=jack_wang@usish.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dan.j.williams@intel.com \
--cc=jfeng@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=maciej.trela@intel.com \
--cc=yuxiangl@marvell.com \
--cc=yxlraid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®