mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jack Wang" <jack_wang@usish.com>
To: "'Xiangliang Yu'" <yuxiangl@marvell.com>,
	"'James Bottomley'" <James.Bottomley@HansenPartnership.com>
Cc: <yxlraid@gmail.com>, <lucas.demarchi@profusion.mobi>,
	<maciej.trela@intel.com>, <dan.j.williams@intel.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"'Jacky Feng'" <jfeng@marvell.com>
Subject: RE: [PATCH] [SCSI] LIBSAS: fix libsas link error issue
Date: Thu, 16 Jun 2011 12:31:34 +0800	[thread overview]
Message-ID: <C8FBA6A948D643679B01520A89FAC48A@usish.com.cn> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FAE66CCA@SC-VEXCH4.marvell.com>

> > [Jack Wang]
> >It's the same, sas_ex_get_linkrate use DISCOVER response as linkrate.
> But the function have problem, actually, the error statement is:
> child->linkrate = min(parent_phy->linkrate, child->max_linkrate);
> its mean like this:
> child->linkrate = min(child_phy->linkrate,
> max(parent->max_linkrate,child_phy->linkrate));
> and if parent->max_linkrate(3Gbps) is less than
child_phy->linkrate(6Gbps),
> the statement will be change this:
> child->linkrate = child_phy->linkrate, forget the parent linkrate.
[Jack Wang] 
I don't think the statement below is error:
child->linkrate = min(parent_phy->linkrate, child->max_linkrate);

parent_phy->linkrate is came from sas_set_ex_phy which will set the linkrate
to negotiated logical linkrate. For your eg: you topo like this:
hba(3G)---expander1(6G)---expander2(6G):

Then expander1's linkrate will set to 3G, and expander2's linkrate will set
to 6G, that is correct. But the connection rate will be 3G from hba to
expander2.


  reply	other threads:[~2011-06-16  4:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 15:17 yxlraid
2011-06-14 15:29 ` James Bottomley
2011-06-15  1:44   ` Xiangliang Yu
2011-06-15  4:15     ` Douglas Gilbert
2011-06-15  4:52       ` Xiangliang Yu
2011-06-15  5:57     ` James Bottomley
2011-06-15  6:31       ` Xiangliang Yu
2011-06-16  1:41         ` Jack Wang
2011-06-16  1:57           ` Xiangliang Yu
2011-06-16  2:18             ` Jack Wang
2011-06-16  2:29               ` Xiangliang Yu
2011-06-16  4:31                 ` Jack Wang [this message]
2011-06-16  4:53                   ` Xiangliang Yu
2011-06-16  6:12                     ` Jack Wang
2011-06-16  6:37                       ` Xiangliang Yu
2011-06-16  6:55                         ` Jack Wang
2011-06-16  7:27                           ` Xiangliang Yu
2011-06-16  8:11                             ` Jack Wang
2011-06-16  9:04                               ` Xiangliang Yu
2011-06-16  9:33                                 ` Jack Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C8FBA6A948D643679B01520A89FAC48A@usish.com.cn \
    --to=jack_wang@usish.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dan.j.williams@intel.com \
    --cc=jfeng@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=maciej.trela@intel.com \
    --cc=yuxiangl@marvell.com \
    --cc=yxlraid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®