From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
openipmi-developer@lists.sourceforge.net,
Arnd Bergmann <arnd@arndb.de>, Corey Minyard <minyard@acm.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ipmi: bt-bmc: Avoid unnecessary judgement
Date: Fri, 3 Apr 2020 21:26:47 +0200 [thread overview]
Message-ID: <6a0e9e0c-e6f3-139e-ae21-83a2e293ef35@web.de> (raw)
> In this function,it will only trigger ifdevice and driver match,and
> the driver has already used the device tree, so the judgement here is
> unnecessary.
Please improve also this commit message (besides a typo).
Regards,
Markus
next reply other threads:[~2020-04-03 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 19:26 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-01 1:25 [PATCH] ipmi:bt-bmc:avoid " Tang Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0e9e0c-e6f3-139e-ae21-83a2e293ef35@web.de \
--to=markus.elfring@web.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®