* Re: [PATCH] ipmi: bt-bmc: Avoid unnecessary judgement
@ 2020-04-03 19:26 Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-04-03 19:26 UTC (permalink / raw)
To: Tang Bin, openipmi-developer, Arnd Bergmann, Corey Minyard,
Greg Kroah-Hartman
Cc: linux-kernel, kernel-janitors
> In this function,it will only trigger ifdevice and driver match,and
> the driver has already used the device tree, so the judgement here is
> unnecessary.
Please improve also this commit message (besides a typo).
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ipmi:bt-bmc:avoid unnecessary judgement
@ 2020-04-01 1:25 Tang Bin
0 siblings, 0 replies; 2+ messages in thread
From: Tang Bin @ 2020-04-01 1:25 UTC (permalink / raw)
To: minyard, arnd; +Cc: gregkh, openipmi-developer, linux-kernel, Tang Bin
In this function,it will only trigger ifdevice and driver match,and
the driver has already used the device tree, so the judgement here is
unnecessary.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/char/ipmi/bt-bmc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index d36aeacb2..890ad55aa 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -430,9 +430,6 @@ static int bt_bmc_probe(struct platform_device *pdev)
struct device *dev;
int rc;
- if (!pdev || !pdev->dev.of_node)
- return -ENODEV;
-
dev = &pdev->dev;
dev_info(dev, "Found bt bmc device\n");
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-03 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 19:26 [PATCH] ipmi: bt-bmc: Avoid unnecessary judgement Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-01 1:25 [PATCH] ipmi:bt-bmc:avoid " Tang Bin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®