From: "luobin (L)" <luobin9@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<luoxianjun@huawei.com>, <yin.yinshi@huawei.com>,
<cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net-next] hinic: add support to set and get pause param
Date: Mon, 18 May 2020 08:51:00 +0800 [thread overview]
Message-ID: <6a340973-ad63-b3e4-a212-4eb9dbe2ee3f@huawei.com> (raw)
In-Reply-To: <20200516.132504.766576117055386086.davem@davemloft.net>
Will fix. Thanks.
On 2020/5/17 4:25, David Miller wrote:
> From: Luo bin <luobin9@huawei.com>
> Date: Sat, 16 May 2020 02:00:30 +0000
>
>> add support to set pause param with ethtool -A and get pause
>> param with ethtool -a. Also remove set_link_ksettings ops for VF.
>>
>> Signed-off-by: Luo bin <luobin9@huawei.com>
> Why are you using a semaphore and not a plain mutex.
>
> Semaphores should be used as an absolute last resort, and only
> after trying vigorously to use other locking primitives.
> .
prev parent reply other threads:[~2020-05-18 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 2:00 Luo bin
2020-05-16 15:14 ` Andrew Lunn
2020-05-16 20:25 ` David Miller
2020-05-18 0:51 ` luobin (L) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a340973-ad63-b3e4-a212-4eb9dbe2ee3f@huawei.com \
--to=luobin9@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®