mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: yung-chuan.liao@linux.intel.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Support clock stop mode 1 if enabled in ACPI
Date: Wed, 11 Mar 2026 16:09:10 +0000	[thread overview]
Message-ID: <6a3aad9b-c6cd-4c2e-951f-1f62d7997ba1@sirena.org.uk> (raw)
In-Reply-To: <c6b8c5e8-fdb6-45a9-aaab-d028e87a90ea@opensource.cirrus.com>

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Wed, Mar 11, 2026 at 03:58:35PM +0000, Richard Fitzgerald wrote:
> On 11/03/2026 3:50 pm, Mark Brown wrote:
> > On Wed, Mar 11, 2026 at 03:34:54PM +0000, Richard Fitzgerald wrote:

> > > mipi-sdw-clock-stop-mode1-supported
> > > This optional Boolean Property shall indicate whether or not Clock-stop
> > > is supported on this Device.
> > > Integer (Boolean)
> > > Values:
> > > False (zero): Clock-stop mode1 is not supported on this Device.
> > > True (nonzero): Clock-stop mode1 is supported on this Device.

> > Oh dear, cute enterprise nonsense hacks :(

> The ACPI spec says that each property must be a {key,value} pair.

> If you always need a value there's the possibility that someone will
> create it with value 0 and expect that to mean false. So relying on its
> presence to indicate true is dodgy, safer to define that the value
> has meaning.

But of course we have the default bool operation doing the just check
for presence thing, and probably people looking at that for a good way
to do these things.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-03-11 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 14:21 Richard Fitzgerald
2026-03-11 15:03 ` Mark Brown
2026-03-11 15:17   ` Richard Fitzgerald
2026-03-11 15:30     ` Mark Brown
2026-03-11 15:34       ` Richard Fitzgerald
2026-03-11 15:50         ` Mark Brown
2026-03-11 15:58           ` Richard Fitzgerald
2026-03-11 16:09             ` Mark Brown [this message]
2026-03-11 18:56 ` Mark Brown
2026-03-14 21:58 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3aad9b-c6cd-4c2e-951f-1f62d7997ba1@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®